From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCHv2 net] bridge: fix igmp / mld query parsing Date: Fri, 06 May 2016 12:56:42 -0400 (EDT) Message-ID: <20160506.125642.581240999988344349.davem@davemloft.net> References: <1462375502-8381-1-git-send-email-linus.luessing@c0d3.blue> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sw@simonwunderlich.de To: linus.luessing@c0d3.blue Return-path: In-Reply-To: <1462375502-8381-1-git-send-email-linus.luessing@c0d3.blue> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Linus L=FCssing Date: Wed, 4 May 2016 17:25:02 +0200 > With the newly introduced helper functions the skb pulling is hidden > in the checksumming function - and undone before returning to the > caller. > = > The IGMP and MLD query parsing functions in the bridge still > assumed that the skb is pointing to the beginning of the IGMP/MLD > message while it is now kept at the beginning of the IPv4/6 header. > = > If there is a querier somewhere else, then this either causes > the multicast snooping to stay disabled even though it could be > enabled. Or, if we have the querier enabled too, then this can > create unnecessary IGMP / MLD query messages on the link. > = > Fixing this by taking the offset between IP and IGMP/MLD header into > account, too. > = > Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code") > Reported-by: Simon Wunderlich > Signed-off-by: Linus L=FCssing Applied and queued up for -stable, thanks.