* [patch] qede: uninitialized variable in qede_start_xmit()
@ 2016-05-05 13:21 Dan Carpenter
2016-05-09 3:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-05-05 13:21 UTC (permalink / raw)
To: Yuval Mintz
Cc: Ariel Elior, everest-linux-l2, netdev, linux-kernel,
kernel-janitors
"data_split" was never set to false. It's just uninitialized.
Fixes: 2950219d87b0 ('qede: Add basic network device support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 60a61c3..d98f35e 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -429,7 +429,7 @@ netdev_tx_t qede_start_xmit(struct sk_buff *skb,
u8 xmit_type;
u16 idx;
u16 hlen;
- bool data_split;
+ bool data_split = false;
/* Get tx-queue context and netdev index */
txq_index = skb_get_queue_mapping(skb);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] qede: uninitialized variable in qede_start_xmit()
2016-05-05 13:21 [patch] qede: uninitialized variable in qede_start_xmit() Dan Carpenter
@ 2016-05-09 3:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-05-09 3:32 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, linux-kernel,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 5 May 2016 16:21:30 +0300
> "data_split" was never set to false. It's just uninitialized.
>
> Fixes: 2950219d87b0 ('qede: Add basic network device support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-09 3:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-05 13:21 [patch] qede: uninitialized variable in qede_start_xmit() Dan Carpenter
2016-05-09 3:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).