From: David Miller <davem@davemloft.net>
To: wxt@rock-chips.com
Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org,
sy.w@outlook.com, al.kochet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: arc/emac: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut
Date: Sun, 08 May 2016 23:42:56 -0400 (EDT) [thread overview]
Message-ID: <20160508.234256.359620681931531068.davem@davemloft.net> (raw)
In-Reply-To: <1462537156-10489-1-git-send-email-wxt@rock-chips.com>
From: Caesar Wang <wxt@rock-chips.com>
Date: Fri, 6 May 2016 20:19:16 +0800
> Doing tx_clean() inside poll() may scramble the tx ring buffer if
> tx() is running. This will cause tx to stop working, which can be
> reproduced by simultaneously downloading two large files at high speed.
>
> Moving tx_clean() into tx() will prevent this. And tx interrupt is no
> longer needed now.
TX completion work is always recommended to be done in the ->poll()
handler.
Fix the race or whatever bug there is rather than working around it,
and regressing the driver, by handling TX completion in the interrupt
handler.
Thanks.
prev parent reply other threads:[~2016-05-09 3:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 12:19 [PATCH v2] net: arc/emac: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut Caesar Wang
2016-05-09 3:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160508.234256.359620681931531068.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=al.kochet@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sy.w@outlook.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).