* [PATCH net] macvtap: segmented packet is consumed
@ 2016-05-06 12:58 Eric Dumazet
2016-05-07 7:44 ` Shmulik Ladkani
2016-05-09 3:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2016-05-06 12:58 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Vlad Yasevich
From: Eric Dumazet <edumazet@google.com>
If GSO packet is segmented and its segments are properly queued,
we call consume_skb() instead of kfree_skb() to be drop monitor
friendly.
Fixes: 3e4f8b7873709 ("macvtap: Perform GSO on forwarding path.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Vlad Yasevich <vyasevic@redhat.com>
---
drivers/net/macvtap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 95394edd1ed5..9a35aa462314 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -373,7 +373,7 @@ static rx_handler_result_t macvtap_handle_frame(struct sk_buff **pskb)
goto wake_up;
}
- kfree_skb(skb);
+ consume_skb(skb);
while (segs) {
struct sk_buff *nskb = segs->next;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] macvtap: segmented packet is consumed
2016-05-06 12:58 [PATCH net] macvtap: segmented packet is consumed Eric Dumazet
@ 2016-05-07 7:44 ` Shmulik Ladkani
2016-05-09 3:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Shmulik Ladkani @ 2016-05-07 7:44 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev, Vlad Yasevich
Hi,
On Fri, 06 May 2016 05:58:21 -0700 Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> If GSO packet is segmented and its segments are properly queued,
> we call consume_skb() instead of kfree_skb() to be drop monitor
> friendly.
>
> Fixes: 3e4f8b7873709 ("macvtap: Perform GSO on forwarding path.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Vlad Yasevich <vyasevic@redhat.com>
Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] macvtap: segmented packet is consumed
2016-05-06 12:58 [PATCH net] macvtap: segmented packet is consumed Eric Dumazet
2016-05-07 7:44 ` Shmulik Ladkani
@ 2016-05-09 3:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-05-09 3:44 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, vyasevic
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 06 May 2016 05:58:21 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> If GSO packet is segmented and its segments are properly queued,
> we call consume_skb() instead of kfree_skb() to be drop monitor
> friendly.
>
> Fixes: 3e4f8b7873709 ("macvtap: Perform GSO on forwarding path.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Vlad Yasevich <vyasevic@redhat.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-09 3:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-06 12:58 [PATCH net] macvtap: segmented packet is consumed Eric Dumazet
2016-05-07 7:44 ` Shmulik Ladkani
2016-05-09 3:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).