From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
f.fainelli@gmail.com
Subject: Re: [PATCH net-next v2 00/21] net: dsa: mv88e6xxx: turn into monolithic driver
Date: Mon, 09 May 2016 15:00:59 -0400 (EDT) [thread overview]
Message-ID: <20160509.150059.1262002047956591909.davem@davemloft.net> (raw)
In-Reply-To: <20160509175647.GE10508@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 9 May 2016 19:56:47 +0200
> On Mon, May 09, 2016 at 01:22:37PM -0400, Vivien Didelot wrote:
>> This patchset merges all mv88e6* drivers supported by the shared
>> mv88e6xxx code into a single mv88e6xxx DSA switch driver.
>>
>> Some flags are added to describe the capabilities of a switch model,
>> such as the presence of a PPU, EEPROM, some old or new registers, etc.
>>
>> First these flags are used to conditionally support the same set of
>> functions in every driver, then specific driver files are removed in
>> favor of the common mv88e6xxx driver.
>>
>> Only the merge of driver specific setup code assumes a few differences.
>> If these differences such as frames priorities are really needed for
>> some models, they can easily be brought back in a future patch.
>>
>> Some inconsistencies might show up, such as the need for
>> MV88E6XXX_FLAG_PPU and MV88E6XXX_FLAG_PPU_ACTIVE flags. But this
>> patchset does not aim to fix them yet. A future patch can do that if
>> they end up being unwanted.
>>
>> The patchset has been tested on interconnected 88E6352 and 88E6185.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> I also tested v1, so
>
> Tested-by: Andrew Lunn <andrew@lunn.ch>
Series applied, thanks everyone.
prev parent reply other threads:[~2016-05-09 19:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 17:22 [PATCH net-next v2 00/21] net: dsa: mv88e6xxx: turn into monolithic driver Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 01/21] net: dsa: mv88e6xxx: add flags to info Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 02/21] net: dsa: mv88e6xxx: factorize PHY access with PPU Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 03/21] net: dsa: mv88e6xxx: factorize PHY indirect access Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 04/21] net: dsa: mv88e6xxx: factorize EEPROM access Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 05/21] net: dsa: mv88e6xxx: factorize temperature access Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 06/21] net: dsa: mv88e6xxx: factorize MAC address setting Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 07/21] net: dsa: mv88e6xxx: factorize EEE access Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 08/21] net: dsa: mv88e6131: add registers access Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 09/21] net: dsa: mv88e6xxx: factorize bridge support Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 10/21] net: dsa: mv88e6xxx: factorize VTU access Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 11/21] net: dsa: mv88e6xxx: factorize ATU access Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 12/21] net: dsa: mv88e6xxx: factorize switch reset Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 13/21] net: dsa: mv88e6xxx: factorize global setup Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 14/21] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 15/21] net: dsa: mv88e6131: drop VLAN Ethertype setup Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 16/21] net: dsa: mv88e6xxx: factorize GLOBAL_MONITOR_CONTROL setup Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 17/21] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL_2 setup Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 18/21] net: dsa: mv88e6131: drop frames priorities setup Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 19/21] net: dsa: mv88e6xxx: factorize switch setup Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 20/21] net: dsa: mv88e6131: use EDSA tag protocol Vivien Didelot
2016-05-09 17:22 ` [PATCH net-next v2 21/21] net: dsa: mv88e6xxx: factorize the switch driver Vivien Didelot
2016-05-09 17:56 ` [PATCH net-next v2 00/21] net: dsa: mv88e6xxx: turn into monolithic driver Andrew Lunn
2016-05-09 19:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509.150059.1262002047956591909.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).