* [PATCH net-next] stmmac: dwmac-socfpga: make socfpga_dwmac_pm_ops static
@ 2016-05-08 11:47 Joachim Eastwood
2016-05-10 2:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joachim Eastwood @ 2016-05-08 11:47 UTC (permalink / raw)
To: davem; +Cc: netdev, peppe.cavallaro, dinguyen, Joachim Eastwood
Fix the following sparse warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:274:1: warning:
symbol 'socfpga_dwmac_pm_ops' was not declared. Should it be static?
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
Hi,
Noticed this sparse warning after my last batch of patches. Not so
easy to spot these when there is a macro that creates variables.
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd9764a..f13499f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -271,7 +271,8 @@ static int socfpga_dwmac_resume(struct device *dev)
}
#endif /* CONFIG_PM_SLEEP */
-SIMPLE_DEV_PM_OPS(socfpga_dwmac_pm_ops, stmmac_suspend, socfpga_dwmac_resume);
+static SIMPLE_DEV_PM_OPS(socfpga_dwmac_pm_ops, stmmac_suspend,
+ socfpga_dwmac_resume);
static const struct of_device_id socfpga_dwmac_match[] = {
{ .compatible = "altr,socfpga-stmmac" },
--
2.8.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] stmmac: dwmac-socfpga: make socfpga_dwmac_pm_ops static
2016-05-08 11:47 [PATCH net-next] stmmac: dwmac-socfpga: make socfpga_dwmac_pm_ops static Joachim Eastwood
@ 2016-05-10 2:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-05-10 2:40 UTC (permalink / raw)
To: manabian; +Cc: netdev, peppe.cavallaro, dinguyen
From: Joachim Eastwood <manabian@gmail.com>
Date: Sun, 8 May 2016 13:47:23 +0200
> Fix the following sparse warning:
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:274:1: warning:
> symbol 'socfpga_dwmac_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-10 2:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-08 11:47 [PATCH net-next] stmmac: dwmac-socfpga: make socfpga_dwmac_pm_ops static Joachim Eastwood
2016-05-10 2:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).