From: Andrew Lunn <andrew@lunn.ch>
To: John Crispin <john@phrozen.org>
Cc: davem@davemloft.net, nbd@nbd.name, netdev@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH V2 04/22] net-next: mediatek: properly handle RGMII modes
Date: Mon, 9 May 2016 14:09:01 +0200 [thread overview]
Message-ID: <20160509120901.GS7972@lunn.ch> (raw)
In-Reply-To: <1462788254-40572-5-git-send-email-john@phrozen.org>
On Mon, May 09, 2016 at 12:03:56PM +0200, John Crispin wrote:
> If an external Gigabit PHY is connected to either of the MACs we need to
> be able to tell the PHY to use a delay. Not doing so will result in heavy
> packet loss and/or data corruption when using PHYs such as the IC+ IP1001.
> We tell the PHY which MII delay mode to use via the devictree.
>
> The ethernet driver needs to be adapted to handle all 3 rgmii-*id modes
> in the same way as normal rgmii when setting up the MAC.
>
> Signed-off-by: John Crispin <john@phrozen.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2016-05-09 12:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 10:03 [PATCH V2 00/22] net-next: mediatek: various fixes and IRQ grouping John Crispin
2016-05-09 10:03 ` [PATCH V2 01/22] net-next: mediatek: use mdiobus_free() in favour of kfree() John Crispin
2016-05-09 12:07 ` Andrew Lunn
2016-05-09 10:03 ` [PATCH V2 02/22] net-next: mediatek: fix gigabit and flow control advertisement John Crispin
2016-05-09 10:03 ` [PATCH V2 03/22] net-next: mediatek: add fixed-phy support John Crispin
2016-05-09 10:03 ` [PATCH V2 04/22] net-next: mediatek: properly handle RGMII modes John Crispin
2016-05-09 12:09 ` Andrew Lunn [this message]
2016-05-09 10:03 ` [PATCH V2 05/22] net-next: mediatek: fix DQL support John Crispin
2016-05-09 10:03 ` [PATCH V2 06/22] net-next: mediatek: add missing return code check John Crispin
2016-05-09 10:03 ` [PATCH V2 07/22] net-next: mediatek: fix missing free of scratch memory John Crispin
2016-05-09 10:04 ` [PATCH V2 08/22] net-next: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin
2016-05-09 10:04 ` [PATCH V2 09/22] net-next: mediatek: dropped rx packets are not being counted properly John Crispin
2016-05-09 10:04 ` [PATCH V2 10/22] net-next: mediatek: add next data pointer coherency protection John Crispin
2016-05-09 10:04 ` [PATCH V2 11/22] net-next: mediatek: disable all interrupts during probe John Crispin
2016-05-09 10:04 ` [PATCH V2 13/22] net-next: mediatek: increase watchdog_timeo John Crispin
2016-05-09 10:04 ` [PATCH V2 15/22] net-next: mediatek: only wake the queue if it is stopped John Crispin
2016-05-09 10:04 ` [PATCH V2 17/22] net-next: mediatek: remove superfluous register reads John Crispin
[not found] ` <1462788254-40572-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-05-09 10:04 ` [PATCH V2 12/22] net-next: mediatek: fix threshold value John Crispin
2016-05-09 10:04 ` [PATCH V2 14/22] net-next: mediatek: fix off by one in the TX ring allocation John Crispin
2016-05-09 10:04 ` [PATCH V2 16/22] net-next: mediatek: remove superfluous queue wake up call John Crispin
2016-05-09 10:04 ` [PATCH V2 18/22] net-next: mediatek: don't use intermediate variables to store IRQ masks John Crispin
2016-05-09 10:04 ` [PATCH V2 20/22] net-next: mediatek: add support for IRQ grouping John Crispin
2016-05-09 10:04 ` [PATCH V2 19/22] net-next: mediatek: add IRQ locking John Crispin
2016-05-09 10:04 ` [PATCH V2 21/22] net-next: mediatek: change my email address John Crispin
2016-05-09 10:04 ` [PATCH V2 22/22] MAINTAINERS: " John Crispin
2016-05-09 16:02 ` [PATCH V2 00/22] net-next: mediatek: various fixes and IRQ grouping David Miller
2016-05-09 16:25 ` John Crispin
2016-05-09 16:28 ` David Miller
2016-05-09 16:34 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509120901.GS7972@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=john@phrozen.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).