From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@mellanox.com>,
Or Gerlitz <gerlitz.or@gmail.com>,
Eugenia Emantayev <eugenia@mellanox.com>,
brouer@redhat.com
Subject: Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context
Date: Tue, 10 May 2016 11:29:47 +0200 [thread overview]
Message-ID: <20160510112947.5a045d1a@redhat.com> (raw)
In-Reply-To: <CAKgT0UfKzKWnNzGpB-915by2M1nzDAdNz-hDwwcwGoowmZefrg@mail.gmail.com>
On Mon, 9 May 2016 13:46:32 -0700
Alexander Duyck <alexander.duyck@gmail.com> wrote:
> > As you also know, tuning the SLUB system will give higher performance,
> > easily. In the future, I'm planning to get some auto-tuning into the
> > SLUB allocator. I've already discussed this with Christiph Lameter, at
> > MM-summit, see presentation[1] slides 4 and 5.
>
> We aren't discussing tuning parameters. We are discussing this patch.
> If you want to argue that with certain tuning parameters this shows
> more performance then bring the numbers, but don't try to bias things.
> If you have to tune the system in some way that nobody will there is
> probably no point in submitting the patch because nobody will use it
> that way.
I think you missed the point. I didn't do parameter tuning for my
benchmarks. I hate tuning parameters, they are huge problem for users
of the kernel.
My point is that I want to implement auto-tuning in the SLUB
allocator. This network stack use-case, will just be one use-case
where the auto-tuning need to show improvements. It is not that
complicated. FreeBSD have this kind of auto-tuning to the workload in
their slab implementation.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-05-10 9:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 13:44 [net-next PATCH V1 0/3] net: enable use of kmem_cache_alloc_bulk in network stack Jesper Dangaard Brouer
2016-05-09 13:44 ` [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context Jesper Dangaard Brouer
2016-05-09 16:20 ` Alexander Duyck
2016-05-09 19:59 ` Jesper Dangaard Brouer
2016-05-09 20:46 ` Alexander Duyck
2016-05-10 9:29 ` Jesper Dangaard Brouer [this message]
2016-05-10 12:30 ` Jesper Dangaard Brouer
2016-05-10 13:48 ` Eric Dumazet
2016-05-10 14:48 ` Jesper Dangaard Brouer
2016-05-10 15:44 ` Eric Dumazet
2016-05-10 17:46 ` Alexander Duyck
2016-05-09 13:44 ` [net-next PATCH V1 2/3] mlx4: use napi_alloc_skb API to get SKB bulk allocations Jesper Dangaard Brouer
2016-05-09 16:47 ` Alexander Duyck
2016-05-09 20:05 ` Jesper Dangaard Brouer
2016-05-09 13:44 ` [net-next PATCH V1 3/3] net: warn on napi_alloc_skb being called in wrong context Jesper Dangaard Brouer
2016-05-09 13:53 ` Sergei Shtylyov
2016-05-09 13:53 ` Sergei Shtylyov
2016-05-09 16:33 ` Alexander Duyck
2016-05-09 20:03 ` Jesper Dangaard Brouer
2016-05-20 8:14 ` [net-next PATCH V1 0/3] net: enable use of kmem_cache_alloc_bulk in network stack Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510112947.5a045d1a@redhat.com \
--to=brouer@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).