* [patch] rtlwifi: rtl818x: silence uninitialized variable warning
@ 2016-05-04 6:16 Dan Carpenter
2016-05-11 18:54 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-05-04 6:16 UTC (permalink / raw)
To: Larry Finger
Cc: Chaoming Li, Kalle Valo, linux-wireless, netdev, linux-kernel,
kernel-janitors
What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an
uninitialized "chnlgroup" variable and probably crash. Maybe that can't
happen for some reason which is not obvious but in that case this patch
is harmless.
Setting it to zero seems like a standard default in the surrounding code
so it's probably fine here as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/rf.c
index 78a81c1..9475aa2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/rf.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/rf.c
@@ -208,8 +208,7 @@ static void _rtl92s_get_txpower_writeval_byregulatory(struct ieee80211_hw *hw,
"Realtek regulatory, 40MHz, writeval = 0x%x\n",
writeval);
} else {
- if (rtlphy->pwrgroup_cnt == 1)
- chnlgroup = 0;
+ chnlgroup = 0;
if (rtlphy->pwrgroup_cnt >= 3) {
if (chnl <= 3)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: rtlwifi: rtl818x: silence uninitialized variable warning
2016-05-04 6:16 [patch] rtlwifi: rtl818x: silence uninitialized variable warning Dan Carpenter
@ 2016-05-11 18:54 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-05-11 18:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Larry Finger, Chaoming Li, linux-wireless, netdev, linux-kernel,
kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an
> uninitialized "chnlgroup" variable and probably crash. Maybe that can't
> happen for some reason which is not obvious but in that case this patch
> is harmless.
>
> Setting it to zero seems like a standard default in the surrounding code
> so it's probably fine here as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
2f8514b8b036 rtlwifi: rtl818x: silence uninitialized variable warning
--
Sent by pwcli
https://patchwork.kernel.org/patch/9010761/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-11 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-04 6:16 [patch] rtlwifi: rtl818x: silence uninitialized variable warning Dan Carpenter
2016-05-11 18:54 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).