From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: rtlwifi: rtl818x: silence uninitialized variable warning Date: Wed, 11 May 2016 18:54:33 +0000 (UTC) Message-ID: <20160511185433.DE30C61344@smtp.codeaurora.org> References: <20160504061639.GB22064@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Larry Finger , Chaoming Li , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: In-Reply-To: <20160504061639.GB22064@mwanda> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Dan Carpenter wrote: > What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an > uninitialized "chnlgroup" variable and probably crash. Maybe that can't > happen for some reason which is not obvious but in that case this patch > is harmless. > > Setting it to zero seems like a standard default in the surrounding code > so it's probably fine here as well. > > Signed-off-by: Dan Carpenter Thanks, 1 patch applied to wireless-drivers-next.git: 2f8514b8b036 rtlwifi: rtl818x: silence uninitialized variable warning -- Sent by pwcli https://patchwork.kernel.org/patch/9010761/