From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, dale.4d@gmail.com,
netdev@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH nf V2] netfilter: fix oops in nfqueue during netns error unwinding
Date: Thu, 12 May 2016 11:47:25 +0200 [thread overview]
Message-ID: <20160512094725.GB1777@salvia> (raw)
In-Reply-To: <1462981273-21676-1-git-send-email-fw@strlen.de>
On Wed, May 11, 2016 at 05:41:13PM +0200, Florian Westphal wrote:
> diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c
> index 5baa8e2..9722819 100644
> --- a/net/netfilter/nf_queue.c
> +++ b/net/netfilter/nf_queue.c
> @@ -102,6 +102,13 @@ void nf_queue_nf_hook_drop(struct net *net, struct nf_hook_ops *ops)
> {
> const struct nf_queue_handler *qh;
>
> + /* netns wasn't initialized, error unwind in progress.
> + * Its possible that the nfq netns init function was not even
> + * called, in which case nfq pernetns data is in undefined state.
> + */
> + if (!net->list.next)
> + return;
Thanks Florian.
Question for the netns folks: Is this a stable assumption? My only
concern with this is that it relies on internal the netns
representation, so I'd like to make sure this thing doesn't break
again.
Let me know, thanks.
next prev parent reply other threads:[~2016-05-12 9:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 15:41 [PATCH nf V2] netfilter: fix oops in nfqueue during netns error unwinding Florian Westphal
2016-05-12 9:47 ` Pablo Neira Ayuso [this message]
2016-05-12 16:15 ` Eric W. Biederman
2016-05-12 16:40 ` Florian Westphal
2016-05-13 19:40 ` Eric W. Biederman
2016-05-13 20:04 ` Florian Westphal
2016-05-13 20:26 ` Eric W. Biederman
2016-05-13 21:07 ` Florian Westphal
2016-05-13 20:44 ` Eric W. Biederman
2016-05-13 21:20 ` Florian Westphal
2016-05-14 0:58 ` Eric W. Biederman
2016-05-14 10:33 ` Florian Westphal
2016-05-15 3:00 ` Eric W. Biederman
2016-05-14 2:18 ` [PATCH] nf_queue: Make the queue_handler pernet Eric W. Biederman
2016-05-30 9:31 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512094725.GB1777@salvia \
--to=pablo@netfilter.org \
--cc=dale.4d@gmail.com \
--cc=ebiederm@xmission.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).