From: Andrew Lunn <andrew@lunn.ch>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, nogahf@mellanox.com,
idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com,
ogerlitz@mellanox.com, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, linville@tuxdriver.com,
tgraf@suug.ch, gospo@cumulusnetworks.com, sfeldma@gmail.com,
sd@queasysnail.net, eranbe@mellanox.com, ast@plumgrid.com,
edumazet@google.com, hannes@stressinduktion.org
Subject: Re: [patch net-next 0/4] return offloaded stats as default and expose original sw start
Date: Thu, 12 May 2016 16:36:45 +0200 [thread overview]
Message-ID: <20160512143645.GE26864@lunn.ch> (raw)
In-Reply-To: <1463047198-10630-1-git-send-email-jiri@resnulli.us>
On Thu, May 12, 2016 at 11:59:54AM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Until now we had stats functions return SW statistics. However, it makes
> a lot of sense to return HW stats as default.
Hi Jiri
DSA has always returned the HW stats, i.e, ethtool -S shows the
counters the switch has for the port.
How do you expect ethtool to handle your change? ethtool -S will print
both sets? Or are you thinking of adding a new flag?
I'm just trying to understand the big picture, and how it affects DSA,
if at all.
Andrew
next prev parent reply other threads:[~2016-05-12 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 9:59 [patch net-next 0/4] return offloaded stats as default and expose original sw start Jiri Pirko
2016-05-12 9:59 ` [patch net-next 1/4] netdevice: add SW statistics ndo Jiri Pirko
2016-05-12 9:59 ` [patch net-next 2/4] rtnetlink: add HW/SW stats distinction in rtnl_fill_stats Jiri Pirko
2016-05-12 9:59 ` [patch net-next 3/4] net: core: add SW stats to if_stats_msg Jiri Pirko
2016-05-12 11:33 ` Nikolay Aleksandrov
2016-05-12 11:44 ` Jiri Pirko
2016-05-12 9:59 ` [patch net-next 4/4] mlxsw: spectrum: Implement SW stats ndo and expose HW stats by default Jiri Pirko
2016-05-12 14:36 ` Andrew Lunn [this message]
2016-05-12 14:48 ` [patch net-next 0/4] return offloaded stats as default and expose original sw start Jiri Pirko
-- strict thread matches above, loose matches on Subject: below --
2016-05-12 11:48 Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512143645.GE26864@lunn.ch \
--to=andrew@lunn.ch \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eladr@mellanox.com \
--cc=eranbe@mellanox.com \
--cc=gospo@cumulusnetworks.com \
--cc=hannes@stressinduktion.org \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=sd@queasysnail.net \
--cc=sfeldma@gmail.com \
--cc=tgraf@suug.ch \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).