From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Tom Herbert <tom@herbertland.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH net-next 04/13] fou: Split out {fou,gue}_build_header
Date: Thu, 12 May 2016 21:55:22 +0300 [thread overview]
Message-ID: <20160512215522.1bc7ec75@halley> (raw)
In-Reply-To: <1462985253-2380625-5-git-send-email-tom@herbertland.com>
Hi Tom,
On Wed, 11 May 2016 09:47:24 -0700 Tom Herbert <tom@herbertland.com> wrote:
>
> -int fou_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> - u8 *protocol, struct flowi4 *fl4);
> -int gue_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> - u8 *protocol, struct flowi4 *fl4);
> +int __fou_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> + u8 *protocol, __be16 *sport, int type);
> +int __gue_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> + u8 *protocol, __be16 *sport, int type);
[snip]
> +EXPORT_SYMBOL(__fou_build_header);
> +
> int fou_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> u8 *protocol, struct flowi4 *fl4)
Assuming 'fou_build_header' is no longer part of the interface, why
not kill the existing EXPORT_SYMBOL(fou_build_header) and make it
static?
Same for 'gue_build_header'.
Regards,
Shmulik
next prev parent reply other threads:[~2016-05-12 18:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 16:47 [PATCH net-next 00/13] ipv6: Enable GUEoIPv6 and more fixes for v6 tunneling Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 01/13] gso: Remove arbitrary checks for unsupported GSO Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 02/13] net: define gso types for IPx over IPv4 and IPv6 Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 03/13] fou: Call setup_udp_tunnel_sock Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 04/13] fou: Split out {fou,gue}_build_header Tom Herbert
2016-05-12 18:55 ` Shmulik Ladkani [this message]
2016-05-11 16:47 ` [PATCH net-next 05/13] fou: Add encap ops for IPv6 tunnels Tom Herbert
2016-05-12 19:26 ` Shmulik Ladkani
2016-05-11 16:47 ` [PATCH net-next 06/13] ipv6: Fix nexthdr for reinjection Tom Herbert
2016-05-12 20:23 ` Shmulik Ladkani
2016-05-12 21:45 ` Tom Herbert
2016-05-13 4:16 ` Shmulik Ladkani
2016-05-13 6:28 ` Shmulik Ladkani
2016-05-13 11:00 ` Shmulik Ladkani
2016-05-11 16:47 ` [PATCH net-next 07/13] ipv6: Change "final" protocol processing for encapsulation Tom Herbert
2016-05-13 6:51 ` Shmulik Ladkani
2016-05-11 16:47 ` [PATCH net-next 08/13] fou: Support IPv6 in fou Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 09/13] ip6_tun: Add infrastructure for doing encapsulation Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 10/13] ip6_gre: Add support for fou/gue encapsulation Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 11/13] ip6_tunnel: " Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 12/13] ip6ip6: Support for GSO/GRO Tom Herbert
2016-05-11 16:47 ` [PATCH net-next 13/13] ip4ip6: " Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512215522.1bc7ec75@halley \
--to=shmulik.ladkani@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).