netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [iproute2 PATCH 1/1] tc fix ife late binding
@ 2016-05-08 15:28 Jamal Hadi Salim
  2016-05-16 18:16 ` Stephen Hemminger
  0 siblings, 1 reply; 4+ messages in thread
From: Jamal Hadi Salim @ 2016-05-08 15:28 UTC (permalink / raw)
  To: stephen; +Cc: netdev, Jamal Hadi Salim

From: Jamal Hadi Salim <jhs@mojatatu.com>

following late action binding didn't work:

sudo tc actions add action ife encode \
type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1

sudo tc filter add dev lo parent ffff: protocol ip prio 2 u32\
match ip src 127.0.0.2/32 flowid 1:2 action ife index 1

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 tc/m_ife.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tc/m_ife.c b/tc/m_ife.c
index ed01ff7..c8ae04d 100644
--- a/tc/m_ife.c
+++ b/tc/m_ife.c
@@ -182,6 +182,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
 				fprintf(stderr, "ife: Illegal \"index\"\n");
 				return -1;
 			}
+			ok++;
 			argc--;
 			argv++;
 		}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [iproute2 PATCH 1/1] tc fix ife late binding
  2016-05-08 15:28 [iproute2 PATCH 1/1] tc fix ife late binding Jamal Hadi Salim
@ 2016-05-16 18:16 ` Stephen Hemminger
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2016-05-16 18:16 UTC (permalink / raw)
  To: Jamal Hadi Salim; +Cc: netdev

On Sun,  8 May 2016 11:28:49 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> From: Jamal Hadi Salim <jhs@mojatatu.com>
> 
> following late action binding didn't work:
> 
> sudo tc actions add action ife encode \
> type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1
> 
> sudo tc filter add dev lo parent ffff: protocol ip prio 2 u32\
> match ip src 127.0.0.2/32 flowid 1:2 action ife index 1
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Ok, applied all the ife patches (for 4.6)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [iproute2 PATCH 1/1] tc fix ife late binding
@ 2016-05-22 17:11 Jamal Hadi Salim
  2016-05-23 23:16 ` Stephen Hemminger
  0 siblings, 1 reply; 4+ messages in thread
From: Jamal Hadi Salim @ 2016-05-22 17:11 UTC (permalink / raw)
  To: stephen; +Cc: netdev, Jamal Hadi Salim

From: Jamal Hadi Salim <jhs@mojatatu.com>

following late binding didn't work

sudo tc actions add action ife encode \
type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 tc/m_ife.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tc/m_ife.c b/tc/m_ife.c
index ed01ff7..c8ae04d 100644
--- a/tc/m_ife.c
+++ b/tc/m_ife.c
@@ -182,6 +182,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
 				fprintf(stderr, "ife: Illegal \"index\"\n");
 				return -1;
 			}
+			ok++;
 			argc--;
 			argv++;
 		}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [iproute2 PATCH 1/1] tc fix ife late binding
  2016-05-22 17:11 Jamal Hadi Salim
@ 2016-05-23 23:16 ` Stephen Hemminger
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2016-05-23 23:16 UTC (permalink / raw)
  To: Jamal Hadi Salim; +Cc: netdev

On Sun, 22 May 2016 13:11:16 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> From: Jamal Hadi Salim <jhs@mojatatu.com>
> 
> following late binding didn't work
> 
> sudo tc actions add action ife encode \
> type 0xDEAD allow mark dst 02:15:15:15:15:15 index 1
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-05-23 23:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-08 15:28 [iproute2 PATCH 1/1] tc fix ife late binding Jamal Hadi Salim
2016-05-16 18:16 ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2016-05-22 17:11 Jamal Hadi Salim
2016-05-23 23:16 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).