From: Andrew Lunn <andrew@lunn.ch>
To: Alexander Graf <agraf@suse.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek@xilinx.com, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO
Date: Mon, 16 May 2016 14:44:44 +0200 [thread overview]
Message-ID: <20160516124444.GB27725@lunn.ch> (raw)
In-Reply-To: <1463398095-123269-1-git-send-email-agraf@suse.de>
On Mon, May 16, 2016 at 01:28:15PM +0200, Alexander Graf wrote:
> The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't enabled.
> It simply passes the device tree test, but leaves all internal configuration
> initialized at 0. Then it configures the phy with those values and renders a
> previously working configuration useless.
>
> This patch makes sure that we only build the DP83867 phy code when
> CONFIG_OF_MDIO is set, to not run into that problem.
Hi Alexander
Looking at the code, the parameters read from device tree are needed
for RGMII mode. What about the case the PHY is used not in RGMII mode?
Could it be there are device trees which legitimately don't have these
properties since they are not needed, and are now going to get
-ENODEV?
Andrew
next prev parent reply other threads:[~2016-05-16 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 11:28 [PATCH] phy dp83867: depend on CONFIG_OF_MDIO Alexander Graf
2016-05-16 12:44 ` Andrew Lunn [this message]
2016-05-16 17:59 ` Alexander Graf
2016-05-16 13:38 ` Dan Murphy
2016-05-16 17:57 ` Alexander Graf
2016-05-16 18:22 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516124444.GB27725@lunn.ch \
--to=andrew@lunn.ch \
--cc=agraf@suse.de \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).