From: David Miller <davem@davemloft.net>
To: ard.biesheuvel@linaro.org
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com,
ricardo.salveti@linaro.org, leif.lindholm@linaro.org,
graeme.gregory@linaro.org, amit.kucheria@linaro.org,
nic_swsd@realtek.com
Subject: Re: [PATCH v2] r8169: default to 64-bit DMA on recent PCIe chips
Date: Tue, 17 May 2016 14:22:38 -0400 (EDT) [thread overview]
Message-ID: <20160517.142238.1044761521251148537.davem@davemloft.net> (raw)
In-Reply-To: <1463258415-31072-1-git-send-email-ard.biesheuvel@linaro.org>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Sat, 14 May 2016 22:40:15 +0200
> The current logic around the 'use_dac' module parameter prevents the
> r81969 driver from being loadable on 64-bit systems without any RAM
> below 4 GB when the parameter is left at its default value.
>
> So introduce a new default value -1 which indicates that 64-bit DMA
> should be enabled on sufficiently recent PCIe chips, i.e., versions
> RTL_GIGA_MAC_VER_18 or later. Explicit param values of 0 or 1 retain
> the existing behavior of unconditionally enabling/disabling 64-bit DMA
> on 64-bit architectures (i.e., regardless of the type and version of the
> chip)
>
> Since PCIe chips do not need to CPlusCmd Dual Address Cycle to be set,
> make that conditional on the device type as well.
>
> Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Applied, let's see what happens...
prev parent reply other threads:[~2016-05-17 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 20:40 [PATCH v2] r8169: default to 64-bit DMA on recent PCIe chips Ard Biesheuvel
2016-05-16 23:11 ` Francois Romieu
2016-05-17 18:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517.142238.1044761521251148537.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amit.kucheria@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=ricardo.salveti@linaro.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).