From: David Miller <davem@davemloft.net>
To: xypron.glpk@gmx.de
Cc: Yisen.Zhuang@huawei.com, yankejian@huawei.com,
lisheng011@huawei.com, liguozhu@huawei.com, andrew@lunn.ch,
salil.mehta@huawei.com, xieqianqian@huawei.com,
huangdaode@hisilicon.com, chenny.xu@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] net: hns: avoid null pointer dereference
Date: Thu, 19 May 2016 11:26:07 -0700 (PDT) [thread overview]
Message-ID: <20160519.112607.1614392639969487509.davem@davemloft.net> (raw)
In-Reply-To: <1463515275-9836-1-git-send-email-xypron.glpk@gmx.de>
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue, 17 May 2016 22:01:15 +0200
> In the statement
> assert(priv || priv->ae_handle);
> the right side of || is only evaluated if priv is null.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
I agree with others that this assert() is pretty useless and should
simply be removed.
prev parent reply other threads:[~2016-05-19 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 20:01 [PATCH 1/1] net: hns: avoid null pointer dereference Heinrich Schuchardt
2016-05-18 1:04 ` Yisen Zhuang
2016-05-19 11:14 ` David Laight
2016-05-19 19:20 ` [PATCH v2 " Heinrich Schuchardt
2016-05-23 20:55 ` David Miller
2016-05-19 18:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519.112607.1614392639969487509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yisen.Zhuang@huawei.com \
--cc=andrew@lunn.ch \
--cc=chenny.xu@huawei.com \
--cc=huangdaode@hisilicon.com \
--cc=liguozhu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=xieqianqian@huawei.com \
--cc=xypron.glpk@gmx.de \
--cc=yankejian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).