From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: hannes@stressinduktion.org, alexei.starovoitov@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] bpf: rather use get_random_int for randomizations
Date: Fri, 20 May 2016 11:24:06 -0700 (PDT) [thread overview]
Message-ID: <20160520.112406.286390667027285394.davem@davemloft.net> (raw)
In-Reply-To: <24461974e8402395c12b3e36b9ac7935b88ef1c2.1463572456.git.daniel@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Wed, 18 May 2016 14:14:28 +0200
> Start address randomization and blinding in BPF currently use
> prandom_u32(). prandom_u32() values are not exposed to unpriviledged
> user space to my knowledge, but given other kernel facilities such as
> ASLR, stack canaries, etc make use of stronger get_random_int(), we
> better make use of it here as well given blinding requests successively
> new random values. get_random_int() has minimal entropy pool depletion,
> is not cryptographically secure, but doesn't need to be for our use
> cases here.
>
> Suggested-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Ok, applied, thanks Daniel.
prev parent reply other threads:[~2016-05-20 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:14 [PATCH net] bpf: rather use get_random_int for randomizations Daniel Borkmann
2016-05-18 13:20 ` Eric Dumazet
2016-05-18 13:28 ` Hannes Frederic Sowa
2016-05-18 14:14 ` Daniel Borkmann
2016-05-18 14:17 ` Eric Dumazet
2016-05-18 21:18 ` Alexei Starovoitov
2016-05-20 18:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520.112406.286390667027285394.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).