From: David Miller <davem@davemloft.net>
To: aryabinin@virtuozzo.com
Cc: hannes@stressinduktion.org, rweikusat@mobileactivedefense.com,
edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] net: sock: move ->sk_shutdown out of bitfields.
Date: Fri, 20 May 2016 18:05:52 -0400 (EDT) [thread overview]
Message-ID: <20160520.180552.293412690344388226.davem@davemloft.net> (raw)
In-Reply-To: <1463588367-16310-1-git-send-email-aryabinin@virtuozzo.com>
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
Date: Wed, 18 May 2016 19:19:27 +0300
> ->sk_shutdown bits share one bitfield with some other bits in sock struct,
> such as ->sk_no_check_[r,t]x, ->sk_userlocks ...
> sock_setsockopt() may write to these bits, while holding the socket lock.
>
> In case of AF_UNIX sockets, we change ->sk_shutdown bits while holding only
> unix_state_lock(). So concurrent setsockopt() and shutdown() may lead
> to corrupting these bits.
>
> Fix this by moving ->sk_shutdown bits out of bitfield into a separate byte.
> This will not change the 'struct sock' size since ->sk_shutdown moved into
> previously unused 16-bit hole.
>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Suggested-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Looks good, applied and queued up for -stable.
Thanks.
prev parent reply other threads:[~2016-05-20 22:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 10:14 [PATCH] net: af_unix: protect ->sk_shutdown change with lock_sock() Andrey Ryabinin
2016-05-18 10:38 ` Hannes Frederic Sowa
2016-05-18 11:23 ` Andrey Ryabinin
2016-05-18 12:03 ` [PATCH v2] net: sock: move ->sk_shutdown out of bitfields Andrey Ryabinin
2016-05-18 13:03 ` Eric Dumazet
2016-05-18 13:14 ` Andrey Ryabinin
2016-05-18 13:49 ` Eric Dumazet
2016-05-18 14:36 ` [PATCH v3] " Andrey Ryabinin
2016-05-18 15:31 ` Eric Dumazet
2016-05-18 16:19 ` [PATCH v4] " Andrey Ryabinin
2016-05-18 17:17 ` Eric Dumazet
2016-05-20 22:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520.180552.293412690344388226.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aryabinin@virtuozzo.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rweikusat@mobileactivedefense.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).