From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] udp: prevent skbs lingering in tunnel socket queues
Date: Fri, 20 May 2016 19:56:43 -0400 (EDT) [thread overview]
Message-ID: <20160520.195643.1333214069455173482.davem@davemloft.net> (raw)
In-Reply-To: <1463666313-12743-1-git-send-email-hannes@stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Thu, 19 May 2016 15:58:33 +0200
> In case we find a socket with encapsulation enabled we should call
> the encap_recv function even if just a udp header without payload is
> available. The callbacks are responsible for correctly verifying and
> dropping the packets.
>
> Also, in case the header validation fails for geneve and vxlan we
> shouldn't put the skb back into the socket queue, no one will pick
> them up there. Instead we can simply discard them in the respective
> encap_recv functions.
>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Looks good, applied and queued up for -stable.
Thanks!
prev parent reply other threads:[~2016-05-20 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 13:58 [PATCH net] udp: prevent skbs lingering in tunnel socket queues Hannes Frederic Sowa
2016-05-19 22:33 ` Cong Wang
2016-05-19 22:50 ` Hannes Frederic Sowa
2016-05-20 1:56 ` Cong Wang
2016-05-20 6:16 ` Hannes Frederic Sowa
2016-05-20 23:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520.195643.1333214069455173482.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).