From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
alexander.duyck@gmail.com
Subject: Re: [PATCHv2] net: suppress warnings on dev_alloc_skb
Date: Fri, 20 May 2016 19:59:01 -0400 (EDT) [thread overview]
Message-ID: <20160520.195901.227587056831866852.davem@davemloft.net> (raw)
In-Reply-To: <1463671854-26829-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 19 May 2016 11:30:54 -0400
> Noticed an allocation failure in a network driver the other day on a 32 bit
> system:
...
> Thought that perhaps the big splat in the logs wasn't really necessecary, as
> all call sites for dev_alloc_skb:
>
> a) check the return code for the function
>
> and
>
> b) either print their own error message or have a recovery path that makes the
> warning moot.
>
> Fix it by modifying dev_alloc_pages to pass __GFP_NOWARN as a gfp flag to
> suppress the warning
>
> applies to the net tree
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks Neil.
prev parent reply other threads:[~2016-05-20 23:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 15:25 [PATCH] net: suppress warnings on dev_alloc_skb Neil Horman
2016-05-18 16:01 ` Eric Dumazet
2016-05-18 17:57 ` Alexander Duyck
2016-05-18 19:29 ` Neil Horman
2016-05-18 20:48 ` Alexander Duyck
2016-05-18 21:09 ` Neil Horman
2016-05-18 21:47 ` Eric Dumazet
2016-05-19 13:34 ` Neil Horman
2016-05-19 15:30 ` [PATCHv2] " Neil Horman
2016-05-19 15:42 ` Eric Dumazet
2016-05-19 15:48 ` Eric Dumazet
2016-05-19 17:34 ` Neil Horman
2016-05-19 17:39 ` Eric Dumazet
2016-05-19 17:52 ` Neil Horman
2016-05-20 23:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520.195901.227587056831866852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.duyck@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).