netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: netdev@vger.kernel.org
Subject: Missing INET6_PROTO_FINAL in l2tp_ip6_protocol?
Date: Sat, 21 May 2016 15:50:03 +0300	[thread overview]
Message-ID: <20160521155003.1410579f@halley> (raw)

Hi,

inet6_protocol's INET6_PROTO_FINAL flag denotes handler is expected not
to request resubmission for local delivery.

For an INET6_PROTO_FINAL handler, the following actions gets executed
prior delivery, in ip6_input_finish:

			nf_reset(skb);

			skb_postpull_rcsum(skb, skb_network_header(skb),
					   skb_network_header_len(skb));

For some reason, l2tp_ip6_protocol handler is NOT marked as
INET6_PROTO_FINAL. Probably an oversight.

Since 'l2tp_ip6_recv' never results in a resubmission, the above actions
are not applied to skbs passed to l2tp_ip6.

Any reason why l2tp_ip6_protocol should NOT be marked INET6_PROTO_FINAL?

What's the consequences not executing the above actions for l2tp_ip6
packets?

Thanks,
Shmulik

             reply	other threads:[~2016-05-21 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21 12:50 Shmulik Ladkani [this message]
2016-05-21 15:55 ` Missing INET6_PROTO_FINAL in l2tp_ip6_protocol? Hannes Frederic Sowa
2016-05-21 20:02   ` Shmulik Ladkani
2016-05-23 11:05     ` Hannes Frederic Sowa
2016-05-23 11:25       ` Shmulik Ladkani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160521155003.1410579f@halley \
    --to=shmulik.ladkani@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).