From: "Michael S. Tsirkin" <mst@redhat.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Tom Herbert <tom@herbertland.com>,
davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v7 net-next 01/16] gso: Remove arbitrary checks for unsupported GSO
Date: Sun, 22 May 2016 10:44:07 +0300 [thread overview]
Message-ID: <20160522074407.GA12660@redhat.com> (raw)
In-Reply-To: <cc2e026a-6ab0-8d52-5c3d-29843c6ddf40@stressinduktion.org>
On Sat, May 21, 2016 at 03:02:30AM +0200, Hannes Frederic Sowa wrote:
> Hello,
>
> On 18.05.2016 18:06, Tom Herbert wrote:
> > In several gso_segment functions there are checks of gso_type against
> > a seemingly arbitrary list of SKB_GSO_* flags. This seems like an
> > attempt to identify unsupported GSO types, but since the stack is
> > the one that set these GSO types in the first place this seems
> > unnecessary to do. If a combination isn't valid in the first
> > place that stack should not allow setting it.
> >
> > This is a code simplication especially for add new GSO types.
>
> I couldn't still wrap my head around this.
>
> I wonder if this is safe in case of if the packet is generated from an
> untrusted virtual machine over virtio_net?
>
> Bye,
> Hannes
I'm not sure how you use virtio_net, but neither it nor tun or macvtap
commonly used as backends for it pass gso flags through
from untrusted entities.
--
MST
next prev parent reply other threads:[~2016-05-22 7:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:06 [PATCH v7 net-next 00/16] ipv6: Enable GUEoIPv6 and more fixes for v6 tunneling Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 01/16] gso: Remove arbitrary checks for unsupported GSO Tom Herbert
2016-05-21 1:02 ` Hannes Frederic Sowa
2016-05-21 3:56 ` Alexander Duyck
2016-05-22 7:44 ` Michael S. Tsirkin [this message]
2016-05-22 12:33 ` Hannes Frederic Sowa
2016-05-22 7:44 ` Michael S. Tsirkin
2016-05-18 16:06 ` [PATCH v7 net-next 02/16] net: define gso types for IPx over IPv4 and IPv6 Tom Herbert
2016-05-18 22:03 ` Jeff Kirsher
2016-05-18 16:06 ` [PATCH v7 net-next 03/16] ipv6: Fix nexthdr for reinjection Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 04/16] ipv6: Change "final" protocol processing for encapsulation Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 05/16] net: Cleanup encap items in ip_tunnels.h Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 06/16] fou: Call setup_udp_tunnel_sock Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 07/16] fou: Split out {fou,gue}_build_header Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 08/16] fou: Support IPv6 in fou Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 09/16] ip6_tun: Add infrastructure for doing encapsulation Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 10/16] fou: Add encap ops for IPv6 tunnels Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 11/16] ip6_gre: Add support for fou/gue encapsulation Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 12/16] ip6_tunnel: " Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 13/16] ipv6: Set features for IPv6 tunnels Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 14/16] ip6ip6: Support for GSO/GRO Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 15/16] ip4ip6: " Tom Herbert
2016-05-18 16:06 ` [PATCH v7 net-next 16/16] ipv6: Don't reset inner headers in ip6_tnl_xmit Tom Herbert
2016-05-18 17:32 ` [PATCH v7 net-next 00/16] ipv6: Enable GUEoIPv6 and more fixes for v6 tunneling Alexander Duyck
2016-05-18 17:40 ` Tom Herbert
2016-05-20 22:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160522074407.GA12660@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).