From: David Miller <davem@davemloft.net>
To: simon.horman@netronome.com
Cc: netdev@vger.kernel.org, tom@herbertland.com, xiyou.wangcong@gmail.com
Subject: Re: [PATCH net v2] fou: avoid using sk_user_data before it is initialised
Date: Mon, 23 May 2016 13:59:51 -0700 (PDT) [thread overview]
Message-ID: <20160523.135951.575984351254086980.davem@davemloft.net> (raw)
In-Reply-To: <1463723837-9098-1-git-send-email-simon.horman@netronome.com>
From: Simon Horman <simon.horman@netronome.com>
Date: Fri, 20 May 2016 14:57:17 +0900
> During initialisation sk->sk_user_data should not be used before
> it is initialised.
>
> Found by bisection after noticing the following:
...
> Fixes: d92283e338f6 ("fou: change to use UDP socket GRO")
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
> ---
> v2
> * Updated implementation to simply access fou->protocol directly
> as suggested by Tom Herbert and Cong Want
I think this was resolved in another way meanwhile. If a fix is still
needed, please respin.
Thanks!
next prev parent reply other threads:[~2016-05-23 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 5:57 [PATCH net v2] fou: avoid using sk_user_data before it is initialised Simon Horman
2016-05-20 16:51 ` Cong Wang
2016-05-23 20:59 ` David Miller [this message]
2016-05-23 21:05 ` Cong Wang
2016-05-24 23:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523.135951.575984351254086980.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).