From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] qed: signedness bug in qed_dcbx_process_tlv() Date: Mon, 23 May 2016 13:19:35 +0300 Message-ID: <20160523101935.GA10712@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ariel Elior , everest-linux-l2@qlogic.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Yuval Mintz , Sudarsana Reddy Kalluru Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:21638 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329AbcEWKTs (ORCPT ); Mon, 23 May 2016 06:19:48 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: "priority" needs to be signed for the error handling to work. Fixes: 39651abd2814 ('qed: add support for dcbx.') Signed-off-by: Dan Carpenter --- Applies to the main net tree. diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c index cbf58e1..a06d19a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c @@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn, struct dcbx_app_priority_entry *p_tbl, u32 pri_tc_tbl, int count, bool dcbx_enabled) { - u8 tc, priority, priority_map; + u8 tc, priority_map; enum dcbx_protocol_type type; u16 protocol_id; + int priority; bool enable; int i;