From: David Miller <davem@davemloft.net>
To: gwshan@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, harish.patil@qlogic.com,
sudarsana.kalluru@qlogic.com, shriyakul@in.ibm.com
Subject: Re: [PATCH] net/qlge: Avoids recursive EEH error
Date: Tue, 24 May 2016 14:48:18 -0700 (PDT) [thread overview]
Message-ID: <20160524.144818.1618490116569101413.davem@davemloft.net> (raw)
In-Reply-To: <1463968708-28368-1-git-send-email-gwshan@linux.vnet.ibm.com>
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
Date: Mon, 23 May 2016 11:58:28 +1000
> One timer, whose handler keeps reading on MMIO register for EEH
> core to detect error in time, is started when the PCI device driver
> is loaded. MMIO register can't be accessed during PE reset in EEH
> recovery. Otherwise, the unexpected recursive error is triggered.
> The timer isn't closed that time if the interface isn't brought
> up. So the unexpected recursive error is seen during EEH recovery
> when the interface is down.
>
> This avoids the unexpected recursive EEH error by closing the timer
> in qlge_io_error_detected() before EEH PE reset unconditionally. The
> timer is started unconditionally after EEH PE reset in qlge_io_resume().
> Also, the timer should be closed unconditionally when the device is
> removed from the system permanently in qlge_io_error_detected().
>
> Reported-by: Shriya R. Kulkarni <shriyakul@in.ibm.com>
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Applied, thanks.
prev parent reply other threads:[~2016-05-24 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 1:58 [PATCH] net/qlge: Avoids recursive EEH error Gavin Shan
2016-05-24 21:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524.144818.1618490116569101413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gwshan@linux.vnet.ibm.com \
--cc=harish.patil@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=shriyakul@in.ibm.com \
--cc=sudarsana.kalluru@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).