From: Sabrina Dubroca <sd@queasysnail.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH iproute2 v3 5/5] ip: add MACsec support
Date: Tue, 24 May 2016 15:12:35 +0200 [thread overview]
Message-ID: <20160524131235.GB23050@bistromath.localdomain> (raw)
In-Reply-To: <20160523162142.0da12bfa@xeon-e3>
Hello Stephen,
2016-05-23, 16:21:42 -0700, Stephen Hemminger wrote:
> On Wed, 18 May 2016 17:35:13 +0200
> Sabrina Dubroca <sd@queasysnail.net> wrote:
>
> > +
> > +static void print_rx_sc(const char *prefix, __u64 sci, __u8 active, struct rtattr *rxsc_stats, struct rtattr *sa)
> > +{
>
> Overall, this looks fine, but could you break some of the really long lines.
> In general, I like iproute2 to follow kernel style, and in general stick to
> the 80 column recommendation where it makes sense. Spliting strings or
> stuff in loops may not make sense. There are several places in this code
> longer than 100 chars.
Ugh, yeah, I forgot to clean this up, sorry.
I'll do that and resend.
Thanks,
--
Sabrina
prev parent reply other threads:[~2016-05-24 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 15:35 [PATCH iproute2 v3 0/5] add MACsec support Sabrina Dubroca
2016-05-18 15:35 ` [PATCH iproute2 v3 1/5] add missing if_macsec.h header from kernel Sabrina Dubroca
2016-05-23 23:07 ` Stephen Hemminger
2016-05-24 13:10 ` Sabrina Dubroca
2016-05-18 15:35 ` [PATCH iproute2 v3 2/5] utils: make hexstring_a2n provide the number of hex digits parsed Sabrina Dubroca
2016-05-18 15:35 ` [PATCH iproute2 v3 3/5] utils: add get_be{16,32,64}, use them where possible Sabrina Dubroca
2016-05-18 15:35 ` [PATCH iproute2 v3 4/5] utils: provide get_hex to read a hex digit from a char Sabrina Dubroca
2016-05-18 15:35 ` [PATCH iproute2 v3 5/5] ip: add MACsec support Sabrina Dubroca
2016-05-23 23:21 ` Stephen Hemminger
2016-05-24 13:12 ` Sabrina Dubroca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524131235.GB23050@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox