* [patch] atm: firestream: add more reserved strings
@ 2016-05-27 10:33 Dan Carpenter
2016-05-31 18:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-05-27 10:33 UTC (permalink / raw)
To: Chas Williams, Patrick van de Lageweg
Cc: linux-atm-general, netdev, kernel-janitors
This bug was there when the driver was first added in back in year 2000.
It causes a Smatch warning:
drivers/atm/firestream.c:849 process_incoming()
error: buffer overflow 'res_strings' 60 <= 63
There are supposed to be 64 entries in this array and the missing
strings are clearly in the 30 40 range. I added them as reserved 37 to
reserved 40. It's possible that strings are really supposed to be added
in the middle instead of at the end, but this approach is safe, in that
it fixes the bug and doesn't break anything that wasn't already broken.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index a969a7e..4777064 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -181,13 +181,17 @@ static char *res_strings[] = {
"reserved 27",
"reserved 28",
"reserved 29",
- "reserved 30",
+ "reserved 30", /* FIXME: The strings between 30-40 might be wrong. */
"reassembly abort: no buffers",
"receive buffer overflow",
"change in GFC",
"receive buffer full",
"low priority discard - no receive descriptor",
"low priority discard - missing end of packet",
+ "reserved 37",
+ "reserved 38",
+ "reserved 39",
+ "reseverd 40",
"reserved 41",
"reserved 42",
"reserved 43",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] atm: firestream: add more reserved strings
2016-05-27 10:33 [patch] atm: firestream: add more reserved strings Dan Carpenter
@ 2016-05-31 18:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-05-31 18:53 UTC (permalink / raw)
To: dan.carpenter; +Cc: 3chas3, patrick, linux-atm-general, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 27 May 2016 13:33:50 +0300
> This bug was there when the driver was first added in back in year 2000.
> It causes a Smatch warning:
>
> drivers/atm/firestream.c:849 process_incoming()
> error: buffer overflow 'res_strings' 60 <= 63
>
> There are supposed to be 64 entries in this array and the missing
> strings are clearly in the 30 40 range. I added them as reserved 37 to
> reserved 40. It's possible that strings are really supposed to be added
> in the middle instead of at the end, but this approach is safe, in that
> it fixes the bug and doesn't break anything that wasn't already broken.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-31 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-27 10:33 [patch] atm: firestream: add more reserved strings Dan Carpenter
2016-05-31 18:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).