From: "George G. Davis" <george_davis@mentor.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Fugang Duan <fugang.duan@nxp.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Russell King <linux@armlinux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API
Date: Tue, 31 May 2016 14:24:50 -0400 [thread overview]
Message-ID: <20160531182450.GA20696@gandalf.middle.earth.net> (raw)
In-Reply-To: <CAOMZO5C7nMsV6LtjtO7AZdj8H4248YBr-DYMQ77z-h9rJhURbg@mail.gmail.com>
Hello Fabio,
On Tue, May 31, 2016 at 02:26:54PM -0300, Fabio Estevam wrote:
> On Tue, May 31, 2016 at 2:17 PM, George G. Davis
> <george_davis@mentor.com> wrote:
> > Convert the i.MX FEC driver and DT files to use the GPIOD API
> > which automatically handles GPIO polarity.
> >
> > Signed-off-by: George G. Davis <george_davis@mentor.com>
>
> In order to avoid breaking old dtb's a property called
> 'phy-reset-active-high' has been introduced.
>
> Check: 962d8cdc3133435a ("net: fec: Rename "phy-reset-active-low"
> property") and 64f10f6ebf5a6d3ae ("net: fec: Add
> "phy-reset-active-low" property to DT").
The GPIOD API handles GPIO active assertion levels as defined by the
DT binding. So the phy-reset-active-high and/or phy-reset-active-low
property is not needed when using the GPIOD API - just define
GPIO_ACTIVE_LOW or GPIO_ACTIVE_HIGH as required for the board and the
GPIOD API will handle active assert/deassert level as needed.
--
Regards,
George
next prev parent reply other threads:[~2016-05-31 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 17:17 [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API George G. Davis
[not found] ` <1464715071-56012-1-git-send-email-george_davis-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2016-05-31 17:26 ` Fabio Estevam
2016-05-31 18:24 ` George G. Davis [this message]
2016-05-31 18:26 ` Russell King - ARM Linux
2016-05-31 18:33 ` George G. Davis
2016-05-31 17:47 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531182450.GA20696@gandalf.middle.earth.net \
--to=george_davis@mentor.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox