From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, Miroslav Kratochvil <exa.exa@gmail.com>
Subject: Re: [PATCH] hfsc: ensure class is added to eltree exactly once
Date: Wed, 1 Jun 2016 01:00:48 +0200 [thread overview]
Message-ID: <20160531230048.GA26552@breakpoint.cc> (raw)
In-Reply-To: <1464706554.5939.105.camel@edumazet-glaptop3.roam.corp.google.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
> > index d783d7c..0854be3 100644
> > --- a/net/sched/sch_hfsc.c
> > +++ b/net/sched/sch_hfsc.c
> > @@ -1583,6 +1583,7 @@ hfsc_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> > {
> > struct hfsc_class *cl;
> > int uninitialized_var(err);
> > + unsigned int qlen;
> >
> > cl = hfsc_classify(skb, sch, &err);
> > if (cl == NULL) {
> > @@ -1592,6 +1593,7 @@ hfsc_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> > return err;
> > }
> >
> > + qlen = cl->qdisc->q.qlen;
> > err = qdisc_enqueue(skb, cl->qdisc);
> > if (unlikely(err != NET_XMIT_SUCCESS)) {
> > if (net_xmit_drop_count(err)) {
> > @@ -1601,7 +1603,7 @@ hfsc_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> > return err;
> > }
> >
> > - if (cl->qdisc->q.qlen == 1)
> > + if (qlen == 0)
> > set_active(cl, qdisc_pkt_len(skb));
> >
> > sch->q.qlen++;
>
> Well, I am not sure HFSC can deal with non work conserving qdisc
> anyway ?
As long as child qdisc dequeue() returns an skb if qlen > 0 it should
work.
> Call to set_active(cl, qdisc_pkt_len(skb)); would tell you that HFSC
> does not expect another packet than @skb being the next dequeued one.
Good point. I'll look into it in more detail but AFAIU this "only"
means we might overshoot a defined realtime/deadline criterion,
I don't (yet) see how it could explain Miroslavs bug report.
> If you want to make HFSC generic, you would need a lot more changes.
Could you elaborate?
I'm not interested in e.g. tbf leaves (makes no sense to me), but I
think it should play nice with netem, sfq, codel, fq_codel, fq, ...
I don't see any problems with fq_codel + hfsc unless I deliberately
misconfigure fq_codel (setting extremely low mem limit, e.g. 32kbyte).
next prev parent reply other threads:[~2016-05-31 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 10:12 [PATCH] hfsc: ensure class is added to eltree exactly once Florian Westphal
2016-05-31 14:55 ` Eric Dumazet
2016-05-31 23:00 ` Florian Westphal [this message]
2016-05-31 23:33 ` Eric Dumazet
2016-05-31 23:49 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531230048.GA26552@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=exa.exa@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).