* [PATCH net-next] ravb: Remove manual pause frame transmit
@ 2016-06-01 16:41 Yoshihiro Kaneko
2016-06-01 16:53 ` Sergei Shtylyov
2016-06-02 6:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yoshihiro Kaneko @ 2016-06-01 16:41 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Sergei Shtylyov, Simon Horman, Magnus Damm,
linux-renesas-soc
From: Masaru Nagai <masaru.nagai.vx@renesas.com>
Writing a non-zero value to the manual PAUSE frame register (MPR) starts
the transmission of a PAUSE frame.
A PAUSE frame is sent in ravb_emac_init(), but it is not expected behavior.
Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the master branch of David Miller's next networking
tree.
drivers/net/ethernet/renesas/ravb_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 867caf6..37dd068 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -362,8 +362,6 @@ static void ravb_emac_init(struct net_device *ndev)
ravb_write(ndev,
(ndev->dev_addr[4] << 8) | (ndev->dev_addr[5]), MALR);
- ravb_write(ndev, 1, MPR);
-
/* E-MAC status register clear */
ravb_write(ndev, ECSR_ICD | ECSR_MPD, ECSR);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ravb: Remove manual pause frame transmit
2016-06-01 16:41 [PATCH net-next] ravb: Remove manual pause frame transmit Yoshihiro Kaneko
@ 2016-06-01 16:53 ` Sergei Shtylyov
2016-06-02 6:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-06-01 16:53 UTC (permalink / raw)
To: Yoshihiro Kaneko, netdev
Cc: David S. Miller, Simon Horman, Magnus Damm, linux-renesas-soc
Hello.
On 06/01/2016 07:41 PM, Yoshihiro Kaneko wrote:
> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
>
> Writing a non-zero value to the manual PAUSE frame register (MPR) starts
> the transmission of a PAUSE frame.
> A PAUSE frame is sent in ravb_emac_init(), but it is not expected behavior.
>
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ravb: Remove manual pause frame transmit
2016-06-01 16:41 [PATCH net-next] ravb: Remove manual pause frame transmit Yoshihiro Kaneko
2016-06-01 16:53 ` Sergei Shtylyov
@ 2016-06-02 6:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-06-02 6:33 UTC (permalink / raw)
To: ykaneko0929
Cc: netdev, sergei.shtylyov, horms, magnus.damm, linux-renesas-soc
From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Date: Thu, 2 Jun 2016 01:41:05 +0900
> From: Masaru Nagai <masaru.nagai.vx@renesas.com>
>
> Writing a non-zero value to the manual PAUSE frame register (MPR) starts
> the transmission of a PAUSE frame.
> A PAUSE frame is sent in ravb_emac_init(), but it is not expected behavior.
>
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-02 6:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-01 16:41 [PATCH net-next] ravb: Remove manual pause frame transmit Yoshihiro Kaneko
2016-06-01 16:53 ` Sergei Shtylyov
2016-06-02 6:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).