From: Vadim Kochan <vadim4j@gmail.com>
To: Phil Sutter <phil@nwl.cc>
Cc: Stephen Hemminger <shemming@brocade.com>,
netdev@vger.kernel.org, Vadim Kochan <vadim4j@gmail.com>
Subject: Re: [iproute PATCH] ipaddress: Allow listing addresses by type
Date: Thu, 2 Jun 2016 00:50:01 +0300 [thread overview]
Message-ID: <20160601215001.GA13978@angus-think.lan> (raw)
In-Reply-To: <1464811047-18642-1-git-send-email-phil@nwl.cc>
On Wed, Jun 01, 2016 at 09:57:27PM +0200, Phil Sutter wrote:
> Not sure why this was limited to ip-link before. It is semantically
> equal to the 'master' keyword, which is not restricted at all.
>
Hi Phil,
I don't remember why I did so, but you are right, it might be
used for 'ip addr' too.
> Cc: Vadim Kochan <vadim4j@gmail.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> ip/ipaddress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index df363b070d5de..1b5ee838ef3fe 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -1613,7 +1613,7 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
> if (!ifindex)
> invarg("Device does not exist\n", *argv);
> filter.master = ifindex;
> - } else if (do_link && strcmp(*argv, "type") == 0) {
> + } else if (strcmp(*argv, "type") == 0) {
> NEXT_ARG();
> filter.kind = *argv;
> } else {
> --
> 2.8.2
>
next prev parent reply other threads:[~2016-06-01 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 19:57 [iproute PATCH] ipaddress: Allow listing addresses by type Phil Sutter
2016-06-01 21:50 ` Vadim Kochan [this message]
[not found] <ba62a9b5ffab44adaf0532dc4ca6725d@HQ1WP-EXMB11.corp.brocade.com>
2016-06-08 15:35 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601215001.GA13978@angus-think.lan \
--to=vadim4j@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox