From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
dinan.gunawardena@netronome.com
Subject: Re: [RFC 02/12] net: cls_bpf: add hardware offload
Date: Wed, 1 Jun 2016 21:59:47 +0100 [thread overview]
Message-ID: <20160601215947.23820510@jkicinski-Precision-T1700> (raw)
In-Reply-To: <574F17CC.8020704@gmail.com>
On Wed, 1 Jun 2016 10:13:48 -0700, John Fastabend wrote:
> > +static void cls_bpf_stop_offload(struct tcf_proto *tp,
> > + struct cls_bpf_prog *prog)
> > +{
> > + struct net_device *dev = tp->q->dev_queue->dev;
> > +
> > + if (!prog->offloaded)
> > + return;
> > + if (WARN_ON(!tc_should_offload(dev, 0)))
> > + return;
>
> This warn on is a bit concerning it looks like you can get
> a program stuck in hardware but removed from the software
> stack. Any idea why this could happen? I think it is better
> to solve the root problem or just remove this if its dbg code.
>
> One thought is you need to block disabling the ethtool flag
> if the hardware has running ebpf codes. Haven't got to the
> driver patches yet though so not sure if you did this or not.
> And now that I think about it I better go check the other
> drivers.
Yes, I do refuse clearing the ethtool flag if offload is active.
I put the warning there in an attempt to document that "this should
never happen". I'll drop it in the next revision.
next prev parent reply other threads:[~2016-06-01 20:59 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 16:50 [RFC 00/12] BPF hardware offload via cls_bpf Jakub Kicinski
2016-06-01 16:50 ` [RFC 01/12] add basic register-field manipulation macros Jakub Kicinski
2016-06-01 20:15 ` Hannes Frederic Sowa
2016-06-01 23:08 ` Jakub Kicinski
2016-06-02 12:01 ` Hannes Frederic Sowa
2016-06-01 16:50 ` [RFC 02/12] net: cls_bpf: add hardware offload Jakub Kicinski
2016-06-01 17:13 ` John Fastabend
2016-06-01 20:59 ` Jakub Kicinski [this message]
2016-06-01 19:34 ` Daniel Borkmann
2016-06-02 7:17 ` Jiri Pirko
2016-06-02 12:07 ` Jakub Kicinski
2016-06-01 16:50 ` [RFC 03/12] net: cls_bpf: limit hardware offload by software-only flag Jakub Kicinski
2016-06-01 17:16 ` John Fastabend
2016-06-01 17:16 ` John Fastabend
2016-06-01 19:40 ` Daniel Borkmann
2016-06-01 21:05 ` Jakub Kicinski
2016-06-01 21:21 ` Daniel Borkmann
2016-06-01 21:26 ` Jakub Kicinski
2016-06-01 21:31 ` Daniel Borkmann
2016-06-02 7:24 ` Jiri Pirko
2016-06-01 16:50 ` [RFC 04/12] net: cls_bpf: add support for marking filters as hardware-only Jakub Kicinski
2016-06-01 17:19 ` John Fastabend
2016-06-01 19:57 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 05/12] nfp: add BPF to NFP code translator Jakub Kicinski
2016-06-01 20:03 ` Daniel Borkmann
2016-06-01 20:09 ` John Fastabend
2016-06-01 20:15 ` Alexei Starovoitov
2016-06-01 21:23 ` Jakub Kicinski
2016-06-02 16:21 ` John Fastabend
2016-06-01 16:50 ` [RFC 06/12] nfp: add hardware cls_bpf offload Jakub Kicinski
2016-06-01 20:20 ` Daniel Borkmann
2016-06-01 20:52 ` Alexei Starovoitov
2016-06-01 21:15 ` Jakub Kicinski
2016-06-01 21:51 ` Alexei Starovoitov
2016-06-01 21:16 ` Daniel Borkmann
2016-06-01 21:36 ` John Fastabend
2016-06-02 6:57 ` Jiri Pirko
2016-06-02 12:13 ` Jakub Kicinski
2016-06-02 12:30 ` Daniel Borkmann
2016-06-01 23:03 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 07/12] nfp: add skb mark support to the bpf offload Jakub Kicinski
2016-06-01 21:56 ` Alexei Starovoitov
2016-06-01 22:19 ` Jakub Kicinski
2016-06-01 22:30 ` Daniel Borkmann
2016-06-01 23:01 ` Jakub Kicinski
2016-06-01 16:50 ` [RFC 08/12] net: cls_bpf: allow offloaded filters to update stats Jakub Kicinski
2016-06-01 17:20 ` John Fastabend
2016-06-01 22:09 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 09/12] nfp: report statistics of offloaded filters Jakub Kicinski
2016-06-01 16:50 ` [RFC 10/12] nfp: bpf: optimize register init Jakub Kicinski
2016-06-01 16:50 ` [RFC 11/12] nfp: bpf: add register rename Jakub Kicinski
2016-06-01 16:50 ` [RFC 12/12] nfp: bpf: add denser mode of execution Jakub Kicinski
2016-06-01 22:01 ` Alexei Starovoitov
2016-06-01 22:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601215947.23820510@jkicinski-Precision-T1700 \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dinan.gunawardena@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox