From: David Miller <davem@davemloft.net>
To: vpalatin@chromium.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
alexandre.torgue@st.com, peppe.cavallaro@st.com
Subject: Re: [PATCH] stmmac: do not sleep in atomic context for mdio_reset
Date: Thu, 02 Jun 2016 12:12:45 -0700 (PDT) [thread overview]
Message-ID: <20160602.121245.1302730459604436490.davem@davemloft.net> (raw)
In-Reply-To: <1464796428-25623-1-git-send-email-vpalatin@chromium.org>
From: Vincent Palatin <vpalatin@chromium.org>
Date: Wed, 1 Jun 2016 08:53:48 -0700
> stmmac_mdio_reset() has been updated to use msleep rather udelay
> (as some PHY requires a one second delay there).
> It called from stmmac_resume() within the spin_lock_irqsave block
> atomic context triggering 'scheduling while atomic'.
>
> The stmmac_priv lock usage is not fully documented, but it seems
> to protect the access to the MAC registers / DMA structures rather
> than the MDIO bus or the PHY (which have separate locking),
> so we can push the spin_lock after the stmmac_mdio_reset call.
>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Applied, thanks.
prev parent reply other threads:[~2016-06-02 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 15:53 [PATCH] stmmac: do not sleep in atomic context for mdio_reset Vincent Palatin
2016-06-02 19:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602.121245.1302730459604436490.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).