From: Tejun Heo <tj@kernel.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue
Date: Thu, 2 Jun 2016 10:57:29 -0400 [thread overview]
Message-ID: <20160602145729.GO14868@mtj.duckdns.org> (raw)
In-Reply-To: <20160602093057.GA15351@Karyakshetra>
On Thu, Jun 02, 2016 at 03:00:57PM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
>
> The workqueue adapter->txrx_wq has workitem
> &adapter->raise_intr_rxdata_task per adapter. Extended Socket Network
> Device is shared memory based, so someone's transmission denotes other's
> reception. raise_intr_rxdata_task raises interruption of receivers from
> the sender in order to notify receivers.
>
> The workqueue adapter->control_wq has workitem
> &adapter->interrupt_watch_task per adapter. interrupt_watch_task is used
> to prevent delay of interrupts.
>
> Dedicated workqueues have been used in both cases since the workitems
> on the workqueues are involved in normal device operation and require
> forward progress under memory pressure.
>
> max_active has been set to 0 since there is no need for throttling
> the number of active work items.
>
> Since network devices may be used for memory reclaim,
> WQ_MEM_RECLAIM has been set to guarantee forward progress.
Patch looks good but ditto with the description. I wish it were
clearer.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-06-02 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:30 [PATCH] net: fjes: fjes_main: Remove create_workqueue Bhaktipriya Shridhar
2016-06-02 14:57 ` Tejun Heo [this message]
2016-06-02 23:55 ` Izumi, Taku
2016-06-04 14:01 ` Bhaktipriya Shridhar
2016-06-04 19:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602145729.GO14868@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=bhaktipriya96@gmail.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=izumi.taku@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).