From: Andrew Lunn <andrew@lunn.ch>
To: Mario_Limonciello@Dell.com
Cc: pali.rohar@gmail.com, hayeswang@realtek.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, anthony.wong@canonical.com
Subject: Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address
Date: Thu, 2 Jun 2016 17:01:18 +0200 [thread overview]
Message-ID: <20160602150118.GB15379@lunn.ch> (raw)
In-Reply-To: <1fdac44606c74fc09bcb95cd0c7f5f87@ausx13mpc124.AMER.DELL.COM>
> >
> > > + pr_info("r8152: Using system auxiliary MAC address");
> >
> > It would be great to write also mac address into that pr_info
And since there could be multiple r8152 in the system, it would be
good to indicate which of them is having its MAC changed. So
netdev_info() or dev_info().
Andrew
next prev parent reply other threads:[~2016-06-02 15:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 21:50 [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Mario Limonciello
2016-06-01 22:27 ` Andrew Lunn
2016-06-01 22:31 ` Mario_Limonciello
2016-06-01 23:06 ` Greg KH
2016-06-02 1:54 ` Mario_Limonciello
2016-06-01 23:05 ` Greg KH
2016-06-02 2:10 ` Mario_Limonciello
2016-06-02 15:22 ` Greg KH
[not found] ` <20160602152244.GA26494-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-06-02 15:46 ` Mario_Limonciello-DYMqY+WieiM
2016-06-02 16:09 ` Greg KH
2016-06-02 16:58 ` Mario_Limonciello
2016-06-03 9:23 ` Hayes Wang
[not found] ` <0835B3720019904CB8F7AA43166CEEB2FED973-JIZ+AM9kKNzuvTFwvkocLypo8c9IxeqyAjHCUHv49ws@public.gmane.org>
2016-06-03 14:52 ` Mario_Limonciello-DYMqY+WieiM
2016-06-02 18:04 ` Bjørn Mork
2016-06-02 18:28 ` Mario_Limonciello
2016-06-02 19:03 ` Pali Rohár
2016-06-02 19:18 ` Mario_Limonciello
2016-06-02 18:44 ` Pali Rohár
2016-06-02 2:53 ` Mario_Limonciello
2016-06-02 8:11 ` Bjørn Mork
2016-06-02 14:29 ` Mario_Limonciello
2016-06-02 7:27 ` Bjørn Mork
2016-06-02 6:10 ` Hayes Wang
2016-06-02 7:46 ` Pali Rohár
2016-06-02 14:45 ` Mario_Limonciello
2016-06-02 15:01 ` Andrew Lunn [this message]
2016-06-02 15:07 ` Mario_Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602150118.GB15379@lunn.ch \
--to=andrew@lunn.ch \
--cc=Mario_Limonciello@Dell.com \
--cc=anthony.wong@canonical.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox