From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: dhowells@redhat.com, rjui@broadcom.com, sbranden@broadcom.com,
jonmason@broadcom.com, linux-afs@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a few KB
Date: Fri, 03 Jun 2016 19:41:48 -0400 (EDT) [thread overview]
Message-ID: <20160603.194148.2116642486783888748.davem@davemloft.net> (raw)
In-Reply-To: <c7437f437c30addd6dafa35b87d7c57061dc752b.1464894331.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 2 Jun 2016 12:08:52 -0700
> Use the more common kernel logging style and reduce object size.
>
> The logging message prefix changes from a mixture of
> "RxRPC:" and "RXRPC:" to "af_rxrpc: ".
>
> $ size net/rxrpc/built-in.o*
> text data bss dec hex filename
> 64172 1972 8304 74448 122d0 net/rxrpc/built-in.o.new
> 67512 1972 8304 77788 12fdc net/rxrpc/built-in.o.old
>
> Miscellanea:
>
> o Consolidate the ASSERT macros to use a single pr_err call with
> decimal and hexadecimal output and a stringified #OP argument
>
> Signed-off-by: Joe Perches <joe@perches.com>
Looks good to me, applied, thanks Joe.
prev parent reply other threads:[~2016-06-03 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 19:08 [PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a few KB Joe Perches
2016-06-03 23:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603.194148.2116642486783888748.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dhowells@redhat.com \
--cc=joe@perches.com \
--cc=jonmason@broadcom.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).