Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pmoore@redhat.com
Cc: netdev@vger.kernel.org, maninder1.s@samsung.com,
	selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org
Subject: Re: [PATCH] netlabel: add address family checks to netlbl_{sock, req}_delattr()
Date: Mon, 06 Jun 2016 14:06:57 -0700 (PDT)	[thread overview]
Message-ID: <20160606.140657.1714281987390130104.davem@davemloft.net> (raw)
In-Reply-To: <CAGH-Kgsftoux6aaJg6c5WCX1sTSpaGoyDN_Y0Od+9Qh+87FD4w@mail.gmail.com>

From: Paul Moore <pmoore@redhat.com>
Date: Mon, 6 Jun 2016 15:37:56 -0400

> On Mon, Jun 6, 2016 at 3:35 PM, Paul Moore <pmoore@redhat.com> wrote:
>> From: Paul Moore <paul@paul-moore.com>
>>
>> It seems risky to always rely on the caller to ensure the socket's
>> address family is correct before passing it to the NetLabel kAPI,
>> especially since we see at least one LSM which didn't. Add address
>> family checks to the *_delattr() functions to help prevent future
>> problems.
>>
>> Cc: <stable@vger.kernel.org>
>> Reported-by: Maninder Singh <maninder1.s@samsung.com>
>> Signed-off-by: Paul Moore <paul@paul-moore.com>
>> ---
>>  net/netlabel/netlabel_kapi.c |   12 ++++++++++--
>>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> DaveM, since this is such a trivial fix I'm adding it into my
> selinux#next branch right now, but if you would prefer to carry it via
> netdev#next let me know.

That's fine.

      reply	other threads:[~2016-06-06 21:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 19:35 [PATCH] netlabel: add address family checks to netlbl_{sock, req}_delattr() Paul Moore
2016-06-06 19:37 ` Paul Moore
2016-06-06 21:06   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606.140657.1714281987390130104.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-security-module@vger.kernel.org \
    --cc=maninder1.s@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=pmoore@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox