netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/2] net: vrf: Improve use of FIB rules
Date: Mon, 06 Jun 2016 15:47:38 -0700 (PDT)	[thread overview]
Message-ID: <20160606.154738.2069568651897544011.davem@davemloft.net> (raw)
In-Reply-To: <1464982616-23030-1-git-send-email-dsa@cumulusnetworks.com>

From: David Ahern <dsa@cumulusnetworks.com>
Date: Fri,  3 Jun 2016 12:36:54 -0700

> Currently, VRFs require 1 oif and 1 iif rule per address family per
> VRF. As the number of VRF devices increases it brings scalability
> issues with the increasing rule list. All of the VRF rules have the
> same format with the exception of the specific table id to direct the
> lookup. Since the table id is available from the oif or iif in the
> loopup, the VRF rules can be consolidated to a single rule that pulls
> the table from the VRF device.
> 
> This solution still allows a user to insert their own rules for VRFs,
> including rules with additional attributes. Accordingly, it is backwards
> compatible with existing setups and allows other policy routing as
> desired.

I hate module parameters.

And you don't even need one in this situation, just use a default preference
of 1000 and add a newlink netlink attribute that can change it.

Thanks.

  parent reply	other threads:[~2016-06-06 22:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 19:36 [PATCH net-next v3 0/2] net: vrf: Improve use of FIB rules David Ahern
2016-06-03 19:36 ` [PATCH net-next v3 1/2] net: Add l3mdev rule David Ahern
2016-06-03 19:36 ` [PATCH net-next v3 2/2] net: vrf: Add l3mdev rules on first device create David Ahern
2016-06-06 22:47 ` David Miller [this message]
2016-06-06 23:47   ` [PATCH net-next v3 0/2] net: vrf: Improve use of FIB rules David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606.154738.2069568651897544011.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).