From: David Miller <davem@davemloft.net>
To: john@phrozen.org
Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
keyhaede@gmail.com, linux-kernel@vger.kernel.org, nbd@nbd.name
Subject: Re: [PATCH 01/12] net: mediatek: fix DQL support
Date: Tue, 07 Jun 2016 16:01:16 -0700 (PDT) [thread overview]
Message-ID: <20160607.160116.2076757909377302163.davem@davemloft.net> (raw)
In-Reply-To: <e1b52f75-edb7-8504-3e6d-40fcb03e39df@phrozen.org>
From: John Crispin <john@phrozen.org>
Date: Mon, 6 Jun 2016 08:43:13 +0200
> i think one solution would be to add some code to have 2 devices share
> the same dql instance. would that be an acceptable solution ?
You still need to address the issue of synchronization.
dql purposefully doesn't use locking, always because a higher level
object (in this case the netdev TX queue) it is contained within
provides the synchronization.
That breaks apart once you share the dql between two netdevs, as you
are proposing here. You'll have to add locking, which is expensive.
That's why I'm trying to encourage you to think out of the box and
find some way to solve the issue without having to access shared
state shared between multiple devices.
Thanks.
next prev parent reply other threads:[~2016-06-07 23:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 6:32 [PATCH 00/12] net: mediatek: various small fixes John Crispin
[not found] ` <1465108385-38286-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-06-05 6:32 ` [PATCH 01/12] net: mediatek: fix DQL support John Crispin
2016-06-05 7:32 ` David Miller
2016-06-06 6:43 ` John Crispin
2016-06-07 23:01 ` David Miller [this message]
2016-06-07 23:20 ` Tom Herbert
2016-06-05 6:32 ` [PATCH 02/12] net: mediatek: add missing return code check John Crispin
2016-06-05 6:32 ` [PATCH 04/12] net: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin
2016-06-05 6:32 ` [PATCH 05/12] net: mediatek: dropped rx packets are not being counted properly John Crispin
2016-06-05 6:32 ` [PATCH 06/12] net: mediatek: add next data pointer coherency protection John Crispin
2016-06-05 6:33 ` [PATCH 07/12] net: mediatek: disable all interrupts during probe John Crispin
2016-06-05 6:33 ` [PATCH 08/12] net: mediatek: fix threshold value John Crispin
2016-06-05 6:33 ` [PATCH 09/12] net: mediatek: increase watchdog_timeo John Crispin
2016-06-05 14:56 ` Andrew Lunn
2016-06-06 6:24 ` John Crispin
2016-06-06 12:21 ` Andrew Lunn
2016-06-06 12:38 ` John Crispin
2016-06-05 6:32 ` [PATCH 03/12] net: mediatek: fix missing free of scratch memory John Crispin
2016-06-05 6:33 ` [PATCH 10/12] net: mediatek: fix off by one in the TX ring allocation John Crispin
2016-06-05 6:33 ` [PATCH 11/12] net: mediatek: only wake the queue if it is stopped John Crispin
2016-06-05 6:33 ` [PATCH 12/12] net: mediatek: remove superfluous queue wake up call John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607.160116.2076757909377302163.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=john@phrozen.org \
--cc=keyhaede@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).