From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemlof.net,
vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net-next v2 2/5] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask
Date: Tue, 7 Jun 2016 02:22:12 +0200 [thread overview]
Message-ID: <20160607002212.GO12165@lunn.ch> (raw)
In-Reply-To: <1465254895-11152-3-git-send-email-f.fainelli@gmail.com>
> @@ -304,6 +312,18 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
> if (err < 0)
> return err;
>
> + if (!ds->slave_mii_bus && ds->drv->phy_read) {
> + ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
> + if (!ds->slave_mii_bus)
> + return err;
> +
> + dsa_slave_mii_bus_init(ds);
> +
> + err = mdiobus_register(ds->slave_mii_bus);
> + if (err < 0)
> + return err;
> + }
> +
> for (index = 0; index < DSA_MAX_PORTS; index++) {
> port = ds->ports[index].dn;
> if (!port)
Hi Florian
This hunk does not seem to fit in this patch.
It is also missing the unregister in dsa_ds_unapply().
Andrew
next prev parent reply other threads:[~2016-06-07 0:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 23:14 [PATCH net-next v2 0/5] net: dsa: misc improvements Florian Fainelli
2016-06-06 23:14 ` [PATCH net-next v2 1/5] net: dsa: Provide unique DSA slave MII bus names Florian Fainelli
2016-06-06 23:14 ` [PATCH net-next v2 2/5] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask Florian Fainelli
2016-06-07 0:22 ` Andrew Lunn [this message]
2016-06-07 13:05 ` Andrew Lunn
2016-06-06 23:14 ` [PATCH net-next v2 3/5] net: dsa: Add initialization helper for CPU port ethtool_ops Florian Fainelli
2016-06-07 13:05 ` Vivien Didelot
2016-06-06 23:14 ` [PATCH net-next v2 4/5] net: dsa: Initialize CPU port ethtool ops per tree Florian Fainelli
2016-06-07 0:34 ` Andrew Lunn
2016-06-06 23:14 ` [PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus Florian Fainelli
2016-06-07 0:39 ` Andrew Lunn
2016-06-07 13:23 ` Vivien Didelot
2016-06-07 14:46 ` Vivien Didelot
2016-06-07 16:48 ` Vivien Didelot
2016-06-07 17:00 ` Andrew Lunn
2016-06-07 17:33 ` Vivien Didelot
2016-06-07 18:44 ` Andrew Lunn
2016-06-07 19:11 ` Vivien Didelot
2016-06-07 19:29 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607002212.GO12165@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemlof.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).