From: David Miller <davem@davemloft.net>
To: g.nault@alphalink.fr
Cc: netdev@vger.kernel.org, tom@herbertland.com, jchapman@katalix.com
Subject: Re: [PATCH v2 net] l2tp: fix configuration passed to setup_udp_tunnel_sock()
Date: Wed, 08 Jun 2016 11:12:34 -0700 (PDT) [thread overview]
Message-ID: <20160608.111234.1806433196448343755.davem@davemloft.net> (raw)
In-Reply-To: <330c38fb18cbe52932e6b4b29cca748f29191fab.1465383438.git.g.nault@alphalink.fr>
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Wed, 8 Jun 2016 12:59:17 +0200
> Unused fields of udp_cfg must be all zeros. Otherwise
> setup_udp_tunnel_sock() fills ->gro_receive and ->gro_complete
> callbacks with garbage, eventually resulting in panic when used by
> udp_gro_receive().
...
> v2: use empty initialiser instead of "{ NULL }" to avoid relying on
> first field's type.
>
> Fixes: 38fd2af24fcf ("udp: Add socket based GRO and config")
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-06-08 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 10:59 [PATCH v2 net] l2tp: fix configuration passed to setup_udp_tunnel_sock() Guillaume Nault
2016-06-08 18:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608.111234.1806433196448343755.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).