From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net-next v4 5/6] net: dsa: Initialize CPU port ethtool ops per tree
Date: Wed, 8 Jun 2016 17:09:35 +0200 [thread overview]
Message-ID: <20160608150935.GI28994@lunn.ch> (raw)
In-Reply-To: <1465342363-28055-6-git-send-email-f.fainelli@gmail.com>
On Tue, Jun 07, 2016 at 04:32:42PM -0700, Florian Fainelli wrote:
> Now that we can properly support multiple distinct trees in the system,
> using a global variable: dsa_cpu_port_ethtool_ops is getting clobbered
> as soon as the second switch tree gets probed, and we don't want that.
>
> We need to move this to be dynamically allocated, and since we can't
> really be comparing addresses anymore to determine first time
> initialization versus any other times, just move this to dsa.c and
> dsa2.c where the remainder of the dst/ds initialization happens.
>
> The operations teardown restores the master netdev's ethtool_ops to its
> original ethtool_ops pointer (typically within the Ethernet driver)
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2016-06-08 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 23:32 [PATCH net-next v4 0/6] net: dsa: misc improvements Florian Fainelli
2016-06-07 23:32 ` [PATCH net-next v4 1/6] net: dsa: Provide unique DSA slave MII bus names Florian Fainelli
2016-06-07 23:32 ` [PATCH net-next v4 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask Florian Fainelli
2016-06-07 23:32 ` [PATCH net-next v4 3/6] net: dsa: Provide a slave MII bus if needed Florian Fainelli
2016-06-07 23:32 ` [PATCH net-next v4 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops Florian Fainelli
2016-06-07 23:32 ` [PATCH net-next v4 5/6] net: dsa: Initialize CPU port ethtool ops per tree Florian Fainelli
2016-06-08 15:09 ` Andrew Lunn [this message]
2016-06-07 23:32 ` [PATCH net-next v4 6/6] net: dsa: bcm_sf2: Register our slave MDIO bus Florian Fainelli
2016-06-08 15:10 ` [PATCH net-next v4 0/6] net: dsa: misc improvements Andrew Lunn
2016-06-08 18:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608150935.GI28994@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).