From: David Miller <davem@davemloft.net>
To: ben.dooks@codethink.co.uk
Cc: linux-kernel@lists.codethink.co.uk, peppe.cavallaro@st.com,
alexandre.torgue@st.com, netdev@vger.kernel.org
Subject: Re: [PATCH] stmmac: fix parameter to dwmac4_set_umac_addr()
Date: Thu, 09 Jun 2016 23:39:24 -0700 (PDT) [thread overview]
Message-ID: <20160609.233924.1271084543681412582.davem@davemloft.net> (raw)
In-Reply-To: <1465410077-25381-1-git-send-email-ben.dooks@codethink.co.uk>
From: Ben Dooks <ben.dooks@codethink.co.uk>
Date: Wed, 8 Jun 2016 19:21:17 +0100
> The dwmac4_set_umac_addr() takes a struct mac_device_info as
> the first parameter, but is being passed a ioaddr instead from
> dwmac4_set_filter(). Fix the warning/bug by changing the first
> parameter.
>
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: expected struct mac_device_info *hw
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: got void [noderef] <asn:2>*ioaddr
>
> Note, only compile tested this as do not have any
> hardware with it in.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Applied.
prev parent reply other threads:[~2016-06-10 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 18:21 [PATCH] stmmac: fix parameter to dwmac4_set_umac_addr() Ben Dooks
2016-06-09 5:32 ` Giuseppe CAVALLARO
2016-06-10 6:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609.233924.1271084543681412582.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).