From: David Miller <davem@davemloft.net>
To: manuel.lauss@gmail.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH] [PATCH v2] net: au1000_eth: fix PHY detection
Date: Fri, 10 Jun 2016 23:35:06 -0700 (PDT) [thread overview]
Message-ID: <20160610.233506.1374606248492334480.davem@davemloft.net> (raw)
In-Reply-To: <20160610221304.694639-1-manuel.lauss@gmail.com>
From: Manuel Lauss <manuel.lauss@gmail.com>
Date: Sat, 11 Jun 2016 00:13:04 +0200
> Commit 7f854420fbfe9d49afe2ffb1df052cfe8e215541
> ("phy: Add API for {un}registering an mdio device to a bus.")
> broke PHY detection on this driver with a copy-paste bug:
> The code is looking 32 times for a PHY at address 0.
>
> Fixes ethernet on AMD DB1100/DB1500/DB1550 boards which have
> their (autodetected) PHYs at address 31.
>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> v2: unbreak "use highest phy addr" case.
I just noticed this and fixed up my tree to use this version instead.
prev parent reply other threads:[~2016-06-11 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 22:13 [PATCH] [PATCH v2] net: au1000_eth: fix PHY detection Manuel Lauss
2016-06-11 6:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610.233506.1374606248492334480.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=manuel.lauss@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).