From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Clark Williams <williams@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
alison@peloton-tech.com
Subject: Re: [PATCH][RT] netpoll: Always take poll_lock when doing polling
Date: Fri, 10 Jun 2016 17:30:51 +0200 [thread overview]
Message-ID: <20160610153051.GA10775@linutronix.de> (raw)
In-Reply-To: <20160526195641.6c26e979@gandalf.local.home>
* Steven Rostedt | 2016-05-26 19:56:41 [-0400]:
>For example:
>
> <interrupt thread (as all interrupts on RT are threaded>
>
> napi_schedule_prep()
> test_and_set_bit(NAPI_STATE_SCHED, &n->state)
>
> <preempted by higher prio task that runs softirqs in its context>
>
> sk_busy_loop()
>
> do {
> rc = busy_poll()
> ret = napi_schedule_prep()
> return !test_and_set_bit(NAPI_STATE_SCHED, &n->state)
> <returns zero because NAPI_STATE_SCHED is set>
> if (!ret) return 0
> <rc is zero>
> } while (...) /* for ever */
>
No, I don't see the busyloop. while() is here:
| while (!nonblock && skb_queue_empty(&sk->sk_receive_queue) &&
| !need_resched() && !busy_loop_timeout(end_time));
and this seems to be the case since v3.11 where it was introduced (but
now it moved to dev.c). So even if there is no busy_poll() and
napi_schedule_prep() returns 0 our cycles here are limited by
busy_loop_timeout().
Sebastian
next prev parent reply other threads:[~2016-06-10 15:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 23:56 [PATCH][RT] netpoll: Always take poll_lock when doing polling Steven Rostedt
2016-06-02 16:12 ` Sebastian Andrzej Siewior
2016-06-04 11:11 ` Steven Rostedt
2016-06-05 15:16 ` Alison Chaiken
2016-06-06 12:03 ` Clark Williams
2016-06-06 23:25 ` Alison Chaiken
2016-06-07 9:46 ` Sebastian Andrzej Siewior
2016-06-08 0:19 ` Alison Chaiken
2016-06-09 12:37 ` Sebastian Andrzej Siewior
2016-09-03 23:40 ` Alison Chaiken
2016-06-10 15:57 ` Sebastian Andrzej Siewior
2016-06-10 16:11 ` Steven Rostedt
2016-06-10 16:20 ` Sebastian Andrzej Siewior
2016-06-10 16:45 ` Steven Rostedt
2016-06-10 15:30 ` Sebastian Andrzej Siewior [this message]
2016-06-10 16:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610153051.GA10775@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alison@peloton-tech.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).