From: Andrew Lunn <andrew@lunn.ch>
To: Clemens Gruber <clemens.gruber@pqgruber.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Sergei Poselenov <sposelenov@emcraft.com>
Subject: Re: [PATCH] phy: marvell: remove LED config override
Date: Fri, 10 Jun 2016 23:15:19 +0200 [thread overview]
Message-ID: <20160610211519.GL2338@lunn.ch> (raw)
In-Reply-To: <20160610205211.GA14243@archie.localdomain>
> We could move that 0x30 LED configuration to .config_init instead of
> .config_aneg, so that if nobody configures it with marvell,reg-init, the
> behavior does not change. I'd have to create a new .config_init function
> for the 1121, 1318 and 1510.
>
> Would you prefer that?
Hi Clemens
Yes, i would prefer that.
Thanks
Andrew
prev parent reply other threads:[~2016-06-10 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 17:42 [PATCH] phy: marvell: remove LED config override Clemens Gruber
2016-06-10 18:38 ` Andrew Lunn
2016-06-10 20:52 ` Clemens Gruber
2016-06-10 21:15 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610211519.GL2338@lunn.ch \
--to=andrew@lunn.ch \
--cc=clemens.gruber@pqgruber.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sposelenov@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).