From: David Miller <davem@davemloft.net>
To: erik.hugne@gmail.com
Cc: tipc-discussion@lists.sourceforge.net, sploving1@gmail.com,
jon.maloy@ericsson.com, netdev@vger.kernel.org,
ying.xue@windriver.com
Subject: Re: [tipc-discussion] [PATCH] tipc: fix potential null pointer dereference in the nla_data function
Date: Sat, 11 Jun 2016 10:32:33 -0700 (PDT) [thread overview]
Message-ID: <20160611.103233.2027314173901979219.davem@davemloft.net> (raw)
In-Reply-To: <CAMXR+-QhKw_Dz+NRcF8PJONEqN997P98dgaSdvdTCKRwj4o1OQ@mail.gmail.com>
From: Erik Hugne <erik.hugne@gmail.com>
Date: Sat, 11 Jun 2016 09:46:32 +0200
> On Jun 11, 2016 08:24, "David Miller" <davem@davemloft.net> wrote:
>>
>> From: Baozeng Ding <sploving1@gmail.com>
>> Date: Fri, 10 Jun 2016 10:26:59 +0800
>>
>> > Before calling the nla_data function, make sure the argument is not
> null.
>> > Fix potential null pointer dereference vulnerability for this.
>> >
>> > Signed-off-by: Baozeng Ding <sploving1@gmail.com>
>>
>> TIPC maintainers, please review.
>>
>
> Nak, nlattrs does not come from userspace in the compat layer, it just
> translates to the legacy TLV thing.
>
> //E
This reply was done in a manner that the Message-ID got lost,
therefore patchwork cannot associate your reply with the original
patch posting and store it in the conversation attached to the patch.
Please don't do that in the future, thanks.
prev parent reply other threads:[~2016-06-11 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:33 [PATCH v2] tipc: fix potential null pointer dereferences in some compat functions Baozeng Ding
2016-05-25 19:34 ` David Miller
2016-06-10 2:26 ` [PATCH] tipc: fix potential null pointer dereference in the nla_data function Baozeng Ding
2016-06-11 6:23 ` David Miller
2016-06-11 7:46 ` Erik Hugne
2016-06-11 17:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160611.103233.2027314173901979219.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=sploving1@gmail.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).