From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: mario_limonciello@dell.com, hayeswang@realtek.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, pali.rohar@gmail.com,
anthony.wong@canonical.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date: Sat, 11 Jun 2016 10:42:26 -0700 (PDT) [thread overview]
Message-ID: <20160611.104226.1571085838142610714.davem@davemloft.net> (raw)
In-Reply-To: <20160611153921.GP2338@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Sat, 11 Jun 2016 17:39:21 +0200
> What is still open is do we want to accept it at all? Do we accept the
> concept of putting the same MAC address on multiple interfaces at
> hotplug time? Do we trust BIOS vendors to not keep changing DSDT
> property name, since it is not standardised?
>
> Do we want this at all should be decided by somebody more senior then
> those passing comments on the code.
Indeed, I think the behavior of using the same MAC address on multiple
interfaces if we plug several of these in at once is not good.
We shouldn't behave this way just because the Microsoft driver does.
next prev parent reply other threads:[~2016-06-11 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:22 [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello
2016-06-11 5:51 ` David Miller
2016-06-11 15:39 ` Andrew Lunn
2016-06-11 17:42 ` David Miller [this message]
2016-06-14 15:08 ` Mario_Limonciello
2016-06-14 16:28 ` Pali Rohár
2016-06-14 16:40 ` Greg KH
2016-06-14 16:47 ` Pali Rohár
2016-06-14 16:55 ` Mario_Limonciello
2016-06-14 17:23 ` Andrew Lunn
2016-06-14 17:58 ` Mario_Limonciello
2016-06-14 18:35 ` David Miller
2016-06-14 22:27 ` Mario_Limonciello
2016-06-22 22:11 ` Mario_Limonciello
2016-07-11 21:54 ` Mario_Limonciello
2016-07-11 22:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160611.104226.1571085838142610714.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=anthony.wong@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=netdev@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).