From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger Date: Mon, 13 Jun 2016 23:21:16 +0200 Message-ID: <20160613212116.GA10478@amd> References: <1462199948-6424-2-git-send-email-jprvita@endlessm.com> <20160504072936.GB17045@amd> <1463045572.13313.21.camel@sipsolutions.net> <20160519071639.GB17077@amd> <1465476194.3442.21.camel@sipsolutions.net> <20160613190048.GA17101@amd> <20160613210109.GA9303@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Johannes Berg , "David S. Miller" , Darren Hart , linux-wireless , Network Development , platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, LKML , linux@endlessm.com, =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita To: =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon 2016-06-13 17:10:02, Jo=E3o Paulo Rechi Vita wrote: > On 13 June 2016 at 17:01, Pavel Machek wrote: > > On Mon 2016-06-13 15:59:35, Jo=E3o Paulo Rechi Vita wrote: > >> On 13 June 2016 at 15:00, Pavel Machek wrote: > >> > Hi! > >> > > >> >> > Jo=E3o, that means you should send a patch to add the ::rfkil= l suffix. > >> >> > > >> >> > >> >> IMO "airplane" (or maybe "airplane-mode") is a better suffix, a= s it > >> >> reflects the label on the machine's chassis. I'll name it > >> >> "asus-wireless::airplane" and send this through platform-driver= s-x86, > >> >> as this is now contained in the platform-drivers-x86 subsystem.= Thanks > >> >> Johannes for your patience and help designing and reviewing the= rfkill > >> >> changes, even if not all of them made it through in the end. An= d > >> >> thanks everyone else involved for the feedback. > >> > > >> > Actually, I'd do '::rfkill', for consistency with other places i= n > >> > /sys. > >> > > >> > /sys/devices/platform/thinkpad_acpi/rfkill/rfkill1/name > >> > /sys/class/rfkill > >> > /sys/module/rfkill > >> > > >> > >> If we use "rfkill" as a suffix, how do you expect userspace to be = able > >> to differentiate between a LED that indicates airplane-mode (LED O= N > >> when all radios are OFF) and a LED that indicates the state of a > >> specific radio like WiFi or Bluetooth (LED ON when that specific r= adio > >> is ON)? If we're going this route we should provide meaningful > >> information here. > > > > '::airplane' has same problem, no? > > >=20 > No, because in this case we would not use "airplane" as a suffix for = a > LED associated with an individual radio. >=20 > > If you want to distinguish that, maybe you can do '::rfkill' for > > everything vs '::rfkill-wifi' for wifi-only and '::rfkill-bt' for > > bluetooth... > > >=20 > The problem here is that the "rfkill" name is already associated with > individual rfkill switches under /sys/class/rfkill, > /sys/devices/platform/*/rfkill etc, so I think we're better off > distinguishing "airplane" vs "wifi" vs "bluetooth" etc, to avoid > confusion. (Actually, "::wifi" is super confusing, I'd expect that to be a led that blinks when wifi is active.) Well... "airplane" is quite confusing. I'd we use "rfkill" for disabling radios, and I believe we should stick with that. But small problem might be polarity. You may need both "::rfkill" and "::not-rfkill". Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses= /blog.html